Skip to content

Add support for two sets of footnotes (alphabetical and numbered). #5

Merged
merged 13 commits into from Apr 22, 2016

Conversation

calcnerd256
Copy link
Contributor

Description

This PR adds two new commands: \EOAfnalph and \EOAfnarabic to allow for two distinct sets of footnotes to be added to a document, one numbered and one alpha-numbered (aa,ab,ac...). These commands are defined to be incompatible with the existing \EOAfn command and using both in the same document will produce an error.

No changes to EOADjango are required to import the xml produced from using these commands because we're outputing XML that is compatible with the existing footnote import.

We're introducing the following new package dependencies, all of which are included inside the TeX Live distribution

  • bigfoot - extends what LaTeX can do with footnotes
  • etex - support for modern LaTeX features
  • alphalph - convert numbers to letters for alpha-numbered footnotes past 26

Motivation and Context

Provides feature specified in issue #4

Screenshots

epub

ibooks-footnotes

PDF

eos_footnotes_pdf

Django

eos_footnotes_django

@calcnerd256
Copy link
Contributor Author

Hey, @lmc . Looking at these screenshots, it seems we don't adequately support \EOAciteauthoryear inside the footnotes in our Django and epub output in the same way that the PDF output does. I'm not sure whether we introduced the changes that broke this or if they are present in the master branch. I would suggest hat we try to reproduce the undesired behavior in master before merging potentially breaking changes from this branch. So let's grab a copy of master and try to generate the offending screenshots from within it.

@calcnerd256
Copy link
Contributor Author

It looks like, even in the old version, nesting an \EOAciteauthoryear inside an \EOAfn looks different in the PDF than it does in the Django and epub outputs.

eos_master_django_footnotes
eos_master_pdf_footnote

Therefore, I feel confident that merging this branch will not introduce this bug. Either the bug already exists in master or it won't exist after the merge.

@lmc lmc changed the title Dev ou footnotes Add support for two sets of footnotes. (alphabetical and numbered) Mar 23, 2016
@lmc lmc changed the title Add support for two sets of footnotes. (alphabetical and numbered) Add support for two sets of footnotes (alphabetical and numbered). Mar 23, 2016
kthoden pushed a commit that referenced this pull request Apr 22, 2016
Add support for two sets of footnotes  (alphabetical and numbered).
@kthoden kthoden merged commit 0edbb80 into master Apr 22, 2016
@kthoden kthoden deleted the dev-ou-footnotes branch August 16, 2018 14:59
Sign in to join this conversation on GitHub.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants