From 61d86e8edc7a0b4e58ec15cc3d53a69e2de95802 Mon Sep 17 00:00:00 2001 From: Schultheis Date: Tue, 18 Sep 2018 17:46:23 +0200 Subject: [PATCH] Prepared submission comments --- cran-comments.md | 51 +++++++++--------------------------------------- 1 file changed, 9 insertions(+), 42 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 57c8438..b2d2f2b 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,57 +1,24 @@ -# Submission 1 +# Submission ## Test environments * local windows 7 install, R 3.5.1 * debian 9.4, R 3.4.1 * win-builder (devel and release) ## R CMD check results -There were no ERRORs or WARNINGs. - -There was 1 NOTE: - -* New submission - -* Possibly mis-spelled words in DESCRIPTION: - Omics (3:30) - omics (9:126) - - Both are spelled correctly. First is capital because of title case. +There were no NOTEs, ERRORs or WARNINGs. ## Downstream dependencies I have also run R CMD check on downstream dependencies of wilson (https://github.molgen.mpg.de/loosolab/wilson/tree/master/revdep). All packages that I could install passed. -## Reviewer comments -Thanks, we see you have lots of cuntions without examples (which may be reasonable given they are not intended t be called by users directly). -Nevertheless, it would be good to have them tested, so please create, if examples are not feasible, at least tests that execute the various functions in your package. - -Best, -Uwe Ligges +## CRAN Message +Dear maintainer of package wilson, -# Submission 2 -## Test environments -* local windows 7 install, R 3.5.1 -* debian 9.4, R 3.4.1 -* win-builder (devel and release) +please see +and find current problems with your package. -## Submission comments -Addressed reviewer comments by adding tests where possible. +Please fix and resubmit before Sep 21 to safely retain the package on CRAN. -## R CMD check results -There were no ERRORs or WARNINGs. - -There was 1 NOTE: - -* New submission - -* Possibly mis-spelled words in DESCRIPTION: - Omics (3:30) - omics (9:126) - - Both are spelled correctly. First is capital because of title case. - -## Downstream dependencies -I have also run R CMD check on downstream dependencies of wilson -(https://github.molgen.mpg.de/loosolab/wilson/tree/master/revdep). -All packages that I could install passed. +Best wishes, +Uwe Ligges