From 6fecbb000d29dde153ce35ec08f663249f234b8e Mon Sep 17 00:00:00 2001 From: Uli Schlachter Date: Thu, 14 Oct 2010 13:26:48 +0200 Subject: [PATCH] XCB: Remove an incorrect clipping optimizations It seems like the idea here was to optimize for the special case of a rectangular clip, where the region operation could be replace by direction operation on the draw extents. However, we cannot modify the geometry for all operations, and in particular the glyphs. So remove this from the common compositing path. This fixes partial-clip-text in the test suite. Signed-off-by: Uli Schlachter Signed-off-by: Chris Wilson --- src/cairo-xcb-surface-render.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/cairo-xcb-surface-render.c b/src/cairo-xcb-surface-render.c index 637a2408b..208d94006 100644 --- a/src/cairo-xcb-surface-render.c +++ b/src/cairo-xcb-surface-render.c @@ -2407,9 +2407,6 @@ _clip_and_composite (cairo_xcb_surface_t *dst, is_empty = ! _cairo_rectangle_intersect (&extents->bounded, &rect); if (unlikely (is_empty && extents->is_bounded)) return CAIRO_STATUS_SUCCESS; - - if (cairo_region_num_rectangles (clip_region) == 1) - clip_region = NULL; } }