From d31dc73f9ba1facdbeee722c022d438f15e5f264 Mon Sep 17 00:00:00 2001 From: Uli Schlachter Date: Wed, 14 Oct 2015 14:22:50 +0200 Subject: [PATCH] xcb: Fix _put_shm_image_boxes if no SHM available This function always returned CAIRO_INT_STATUS_SUCCESS, even if it didn't do anything. This commit makes the function return CAIRO_INT_STATUS_UNSUPPORTED instead. No unit test for this, because we currently do not test the !SHM case automatically. Perhaps we should? Signed-off-by: Uli Schlachter --- src/cairo-xcb-surface.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/cairo-xcb-surface.c b/src/cairo-xcb-surface.c index d7e0d734e..2403a0d80 100644 --- a/src/cairo-xcb-surface.c +++ b/src/cairo-xcb-surface.c @@ -646,9 +646,8 @@ _put_shm_image_boxes (cairo_xcb_surface_t *surface, shm_info->offset); } } + return CAIRO_INT_STATUS_SUCCESS; } - - return CAIRO_INT_STATUS_SUCCESS; #endif return CAIRO_INT_STATUS_UNSUPPORTED;