Skip to content

Commit

Permalink
git-gui: Stop deleting gitk preferences.
Browse files Browse the repository at this point in the history
Now that git 1.5.0 and later contains a version of gitk that uses
correct geometry on Windows platforms, even if ~/.gitk exists, we
should not delete the user's ~/.gitk to work around the bug.  It
is downright mean to remove a user's preferences for another app.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
  • Loading branch information
Shawn O. Pearce committed Feb 11, 2007
1 parent d585e78 commit 0960f7d
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions git-gui.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4015,14 +4015,6 @@ set starting_gitk_msg {Starting gitk... please wait...}
proc do_gitk {revs} {
global env ui_status_value starting_gitk_msg

# -- On Windows gitk is severly broken, and right now it seems like
# nobody cares about fixing it. The only known workaround is to
# always delete ~/.gitk before starting the program.
#
if {[is_Windows]} {
catch {file delete [file join $env(HOME) .gitk]}
}

# -- Always start gitk through whatever we were loaded with. This
# lets us bypass using shell process on Windows systems.
#
Expand Down

0 comments on commit 0960f7d

Please sign in to comment.