Skip to content

Commit

Permalink
git-gui: Jump to the first annotation block as soon as its available.
Browse files Browse the repository at this point in the history
To help clue users into the fact that annotation data arrives
incrementally, and that they should try to locate the region
they want while the tool is running, we jump to the first line
of the first annotation if the user has not already clicked on
a line they are interested in and if the window is still looking
at the very top of the file.

Since it takes a second (at least on my PowerBook) to even generate
the first annotation for git-gui.sh, the user should have plenty of
time to adjust the scrollbar or click on a line even before we get
that first annotation record in, which allows the user to bypass
our automatic jumping.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
  • Loading branch information
Shawn O. Pearce committed Feb 9, 2007
1 parent 6910ae8 commit 1351ba1
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion git-gui.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3425,7 +3425,12 @@ proc read_blame_incremental {fd w w_cmit w_line w_file} {
$w_line tag add g$cmit $lno.0 "$lno.0 lineend + 1c"
$w_file tag add g$cmit $lno.0 "$lno.0 lineend + 1c"

if {$blame_data($w,highlight_line) == $lno} {
if {$blame_data($w,highlight_line) == -1} {
if {[lindex [$w_file yview] 0] == 0} {
$w_file see $lno.0
blame_showcommit $w $w_cmit $w_line $w_file $lno
}
} elseif {$blame_data($w,highlight_line) == $lno} {
blame_showcommit $w $w_cmit $w_line $w_file $lno
}

Expand Down

0 comments on commit 1351ba1

Please sign in to comment.