Skip to content

Commit

Permalink
check-ref-format: simplify --print implementation
Browse files Browse the repository at this point in the history
normalize_path_copy() is a complicated function, but most of its
functionality will never apply to a ref name that has been checked
with check_ref_format().

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jonathan Nieder authored and Junio C Hamano committed Oct 13, 2009
1 parent 38eedc6 commit 1ba447b
Showing 1 changed file with 23 additions and 2 deletions.
25 changes: 23 additions & 2 deletions builtin-check-ref-format.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,28 @@
#include "builtin.h"
#include "strbuf.h"

/*
* Replace each run of adjacent slashes in src with a single slash,
* and write the result to dst.
*
* This function is similar to normalize_path_copy(), but stripped down
* to meet check_ref_format's simpler needs.
*/
static void collapse_slashes(char *dst, const char *src)
{
char ch;
char prev = '\0';

while ((ch = *src++) != '\0') {
if (prev == '/' && ch == prev)
continue;

*dst++ = ch;
prev = ch;
}
*dst = '\0';
}

int cmd_check_ref_format(int argc, const char **argv, const char *prefix)
{
if (argc == 3 && !strcmp(argv[1], "--branch")) {
Expand All @@ -22,8 +44,7 @@ int cmd_check_ref_format(int argc, const char **argv, const char *prefix)

if (check_ref_format(argv[2]))
exit(1);
if (normalize_path_copy(refname, argv[2]))
die("Could not normalize ref name '%s'", argv[2]);
collapse_slashes(refname, argv[2]);
printf("%s\n", refname);
exit(0);
}
Expand Down

0 comments on commit 1ba447b

Please sign in to comment.