Skip to content

Commit

Permalink
Add -v and --abbrev options to git-branch
Browse files Browse the repository at this point in the history
The new -v option makes git-branch show the abbreviated sha1 + subjectline
for each branch.

Additionally, minimum abbreviation length can be specified with
--abbrev=<length>

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Lars Hjemli authored and Junio C Hamano committed Nov 25, 2006
1 parent 983d2ee commit 75e6e21
Show file tree
Hide file tree
Showing 2 changed files with 51 additions and 6 deletions.
9 changes: 8 additions & 1 deletion Documentation/git-branch.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ git-branch - List, create, or delete branches.
SYNOPSIS
--------
[verse]
'git-branch' [-r] [-a]
'git-branch' [-r] [-a] [-v] [--abbrev=<length>]
'git-branch' [-l] [-f] <branchname> [<start-point>]
'git-branch' (-d | -D) <branchname>...

Expand Down Expand Up @@ -52,6 +52,13 @@ OPTIONS
-a::
List both remote-tracking branches and local branches.

-v::
Show sha1 and subject message for each head.

--abbrev=<length>::
Alter minimum display length for sha1 in output listing,
default value is 7.

<branchname>::
The name of the branch to create or delete.
The new branch name must pass all checks defined by
Expand Down
48 changes: 43 additions & 5 deletions builtin-branch.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#include "builtin.h"

static const char builtin_branch_usage[] =
"git-branch (-d | -D) <branchname> | [-l] [-f] <branchname> [<start-point>] | [-r] | [-a]";
"git-branch (-d | -D) <branchname> | [-l] [-f] <branchname> [<start-point>] | [-r | -a] [-v] [--abbrev=<length>] ";


static const char *head;
Expand Down Expand Up @@ -87,10 +87,11 @@ static void delete_branches(int argc, const char **argv, int force)
struct ref_item {
char *name;
unsigned int kind;
unsigned char sha1[20];
};

struct ref_list {
int index, alloc;
int index, alloc, maxwidth;
struct ref_item *list;
int kinds;
};
Expand All @@ -100,6 +101,7 @@ static int append_ref(const char *refname, const unsigned char *sha1, int flags,
struct ref_list *ref_list = (struct ref_list*)(cb_data);
struct ref_item *newitem;
int kind = REF_UNKNOWN_TYPE;
int len;

/* Detect kind */
if (!strncmp(refname, "refs/heads/", 11)) {
Expand Down Expand Up @@ -128,6 +130,10 @@ static int append_ref(const char *refname, const unsigned char *sha1, int flags,
newitem = &(ref_list->list[ref_list->index++]);
newitem->name = xstrdup(refname);
newitem->kind = kind;
hashcpy(newitem->sha1, sha1);
len = strlen(newitem->name);
if (len > ref_list->maxwidth)
ref_list->maxwidth = len;

return 0;
}
Expand All @@ -151,7 +157,24 @@ static int ref_cmp(const void *r1, const void *r2)
return strcmp(c1->name, c2->name);
}

static void print_ref_list(int kinds)
static void print_ref_info(const unsigned char *sha1, int abbrev)
{
struct commit *commit;
char subject[256];


commit = lookup_commit(sha1);
if (commit && !parse_commit(commit))
pretty_print_commit(CMIT_FMT_ONELINE, commit, ~0,
subject, sizeof(subject), 0,
NULL, NULL, 0);
else
strcpy(subject, " **** invalid ref ****");

printf(" %s %s\n", find_unique_abbrev(sha1, abbrev), subject);
}

static void print_ref_list(int kinds, int verbose, int abbrev)
{
int i;
char c;
Expand All @@ -169,7 +192,13 @@ static void print_ref_list(int kinds)
!strcmp(ref_list.list[i].name, head))
c = '*';

printf("%c %s\n", c, ref_list.list[i].name);
if (verbose) {
printf("%c %-*s", c, ref_list.maxwidth,
ref_list.list[i].name);
print_ref_info(ref_list.list[i].sha1, abbrev);
}
else
printf("%c %s\n", c, ref_list.list[i].name);
}

free_ref_list(&ref_list);
Expand Down Expand Up @@ -215,6 +244,7 @@ static void create_branch(const char *name, const char *start,
int cmd_branch(int argc, const char **argv, const char *prefix)
{
int delete = 0, force_delete = 0, force_create = 0;
int verbose = 0, abbrev = DEFAULT_ABBREV;
int reflog = 0;
int kinds = REF_LOCAL_BRANCH;
int i;
Expand Down Expand Up @@ -255,6 +285,14 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
reflog = 1;
continue;
}
if (!strncmp(arg, "--abbrev=", 9)) {
abbrev = atoi(arg+9);
continue;
}
if (!strcmp(arg, "-v")) {
verbose = 1;
continue;
}
usage(builtin_branch_usage);
}

Expand All @@ -268,7 +306,7 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
if (delete)
delete_branches(argc - i, argv + i, force_delete);
else if (i == argc)
print_ref_list(kinds);
print_ref_list(kinds, verbose, abbrev);
else if (i == argc - 1)
create_branch(argv[i], head, force_create, reflog);
else if (i == argc - 2)
Expand Down

0 comments on commit 75e6e21

Please sign in to comment.