Skip to content

Commit

Permalink
send-email: ask confirmation if given encoding name is very short
Browse files Browse the repository at this point in the history
Sometimes people respond "y<ENTER>" (or "yes<ENTER>") when asked
this question:

    Which 8bit encoding should I declare [UTF-8]?

We already have a mechanism to avoid accepting a mistyped e-mail
address (we ask to confirm when the given address lacks "@" in it);
reuse it to trigger the same confirmation when given a very short
answer.  As a typical charset name is probably at least 4 chars or
longer (e.g. "UTF8" spelled without the dash, or "Big5"), this would
prevent such a mistake.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Feb 13, 2015
1 parent 3d8a54e commit 852a15d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions git-send-email.perl
Original file line number Diff line number Diff line change
Expand Up @@ -733,6 +733,7 @@ sub file_declares_8bit_cte {
print " $f\n";
}
$auto_8bit_encoding = ask("Which 8bit encoding should I declare [UTF-8]? ",
valid_re => qr/.{4}/, confirm_only => 1,
default => "UTF-8");
}

Expand Down

0 comments on commit 852a15d

Please sign in to comment.