Skip to content

Commit

Permalink
t9365-continuing-queries.sh: use the $( ... ) construct for command s…
Browse files Browse the repository at this point in the history
…ubstitution

The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command
substitution, and is supported by POSIX.  However, all but the
simplest uses become complicated quickly.  In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.

The patch was generated by:

for _f in $(find . -name "*.sh")
do
   sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

and then carefully proof-read.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Elia Pinto authored and Junio C Hamano committed Apr 23, 2014
1 parent bd368a9 commit 9bfeaa0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion contrib/mw-to-git/t/t9365-continuing-queries.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ test_check_precond

test_expect_success 'creating page w/ >500 revisions' '
wiki_reset &&
for i in `test_seq 501`
for i in $(test_seq 501)
do
echo "creating revision $i" &&
wiki_editpage foo "revision $i<br/>" true
Expand Down

0 comments on commit 9bfeaa0

Please sign in to comment.