Skip to content

Commit

Permalink
Merge branch 'jc/maint-read-tree-multi' into maint-1.6.2
Browse files Browse the repository at this point in the history
* jc/maint-read-tree-multi:
  Revert "checkout branch: prime cache-tree fully"
  • Loading branch information
Junio C Hamano committed May 12, 2009
2 parents 58e93fa + 49d833d commit a83502f
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 8 deletions.
9 changes: 1 addition & 8 deletions builtin-checkout.c
Original file line number Diff line number Diff line change
Expand Up @@ -368,17 +368,14 @@ static int merge_working_tree(struct checkout_opts *opts,
int ret;
struct lock_file *lock_file = xcalloc(1, sizeof(struct lock_file));
int newfd = hold_locked_index(lock_file, 1);
int reprime_cache_tree = 0;

if (read_cache() < 0)
return error("corrupt index file");

cache_tree_free(&active_cache_tree);
if (opts->force) {
ret = reset_tree(new->commit->tree, opts, 1);
if (ret)
return ret;
reprime_cache_tree = 1;
} else {
struct tree_desc trees[2];
struct tree *tree;
Expand Down Expand Up @@ -414,9 +411,7 @@ static int merge_working_tree(struct checkout_opts *opts,
init_tree_desc(&trees[1], tree->buffer, tree->size);

ret = unpack_trees(2, trees, &topts);
if (ret != -1) {
reprime_cache_tree = 1;
} else {
if (ret == -1) {
/*
* Unpack couldn't do a trivial merge; either
* give up or do a real merge, depending on
Expand Down Expand Up @@ -460,8 +455,6 @@ static int merge_working_tree(struct checkout_opts *opts,
}
}

if (reprime_cache_tree)
prime_cache_tree(&active_cache_tree, new->commit->tree);
if (write_cache(newfd, active_cache, active_nr) ||
commit_locked_index(lock_file))
die("unable to write new index file");
Expand Down
28 changes: 28 additions & 0 deletions t/t2014-switch.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
#!/bin/sh

test_description='Peter MacMillan'
. ./test-lib.sh

test_expect_success setup '
echo Hello >file &&
git add file &&
test_tick &&
git commit -m V1 &&
echo Hello world >file &&
git add file &&
git checkout -b other
'

test_expect_success 'check all changes are staged' '
git diff --exit-code
'

test_expect_success 'second commit' '
git commit -m V2
'

test_expect_success 'check' '
git diff --cached --exit-code
'

test_done

0 comments on commit a83502f

Please sign in to comment.