Skip to content

Commit

Permalink
Merge branch 'fc/git-complete-helper-fix'
Browse files Browse the repository at this point in the history
Resurrects old behaviour of _git/_gitk for external users.
  • Loading branch information
Junio C Hamano committed May 25, 2012
2 parents aed79af + b0a4b2d commit b19ea23
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 6 deletions.
22 changes: 17 additions & 5 deletions contrib/completion/git-completion.bash
Original file line number Diff line number Diff line change
Expand Up @@ -2597,7 +2597,7 @@ _git_whatchanged ()
_git_log
}

_git ()
_main_git ()
{
local i c=1 command __git_dir

Expand Down Expand Up @@ -2648,7 +2648,7 @@ _git ()
fi
}

_gitk ()
_main_gitk ()
{
__git_has_doubledash && return

Expand Down Expand Up @@ -2700,13 +2700,25 @@ __git_complete ()
|| complete -o default -o nospace -F $wrapper $1
}

__git_complete git _git
__git_complete gitk _gitk
# wrapper for backwards compatibility
_git ()
{
__git_wrap_main_git
}

# wrapper for backwards compatibility
_gitk ()
{
__git_wrap_main_gitk
}

__git_complete git _main_git
__git_complete gitk _main_gitk

# The following are necessary only for Cygwin, and only are needed
# when the user has tab-completed the executable name and consequently
# included the '.exe' suffix.
#
if [ Cygwin = "$(uname -o 2>/dev/null)" ]; then
__git_complete git.exe _git
__git_complete git.exe _main_git
fi
2 changes: 1 addition & 1 deletion t/t9902-completion.sh
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ run_completion ()
local _cword
_words=( $1 )
(( _cword = ${#_words[@]} - 1 ))
__git_wrap_git && print_comp
__git_wrap_main_git && print_comp
}

test_completion ()
Expand Down

0 comments on commit b19ea23

Please sign in to comment.