From d6d1a75e51cf90650ac6e2cdcd8d108324b6fdb9 Mon Sep 17 00:00:00 2001 From: Jeff King Date: Fri, 12 Jun 2015 17:28:14 -0400 Subject: [PATCH] pkt-line: tighten sideband PACK check when tracing To find the start of the pack data, we accept the word PACK at the beginning of any sideband channel, even though what we really want is to find the pack data on channel 1. In practice this doesn't matter, as sideband-2 messages tend to start with "error:" or similar, but it is a good idea to be explicit (especially as we add more code in this area, we will rely on this assumption). Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- pkt-line.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkt-line.c b/pkt-line.c index 0477d2eef..e75af023b 100644 --- a/pkt-line.c +++ b/pkt-line.c @@ -24,7 +24,7 @@ static void packet_trace(const char *buf, unsigned int len, int write) strbuf_addf(&out, "packet: %12s%c ", packet_trace_prefix, write ? '>' : '<'); - if (starts_with(buf, "PACK") || starts_with(buf + 1, "PACK")) { + if (starts_with(buf, "PACK") || starts_with(buf, "\1PACK")) { strbuf_addstr(&out, "PACK ..."); trace_disable(&trace_packet); }