Skip to content

Commit

Permalink
git-sh-setup: Fix scripts whose PWD is a symlink to a work-dir on OS X
Browse files Browse the repository at this point in the history
On Mac OS X and possibly BSDs, /bin/pwd reads PWD from the environment if
available and shows the logical path by default rather than the physical
one.

Unset PWD before running /bin/pwd in both cd_to_toplevel and its test.

Still use the external /bin/pwd because in my Bash on Linux, the builtin
pwd prints the same result whether or not PWD is set.

Signed-off-by: Marcel M. Cary <marcel@oak.homeunix.org>
Tested-by: Wincent Colaiuta <win@wincent.com> (on Mac OS X 10.5.5)
Tested-by: Marcel Koeppen <git-dev@marzelpan.de> (on Mac OS X 10.5.6)
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Marcel M. Cary authored and Junio C Hamano committed Jan 5, 2009
1 parent 8104ebf commit dd6c136
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion git-sh-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ cd_to_toplevel () {
..|../*|*/..|*/../*)
# Interpret $cdup relative to the physical, not logical, cwd.
# Probably /bin/pwd is more portable than passing -P to cd or pwd.
phys="$(/bin/pwd)/$cdup"
phys="$(unset PWD; /bin/pwd)/$cdup"
;;
*)
# There's no "..", so no need to make things absolute.
Expand Down
4 changes: 2 additions & 2 deletions t/t2300-cd-to-toplevel.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ test_cd_to_toplevel () {
cd '"'$1'"' &&
. git-sh-setup &&
cd_to_toplevel &&
[ "$(/bin/pwd)" = "$TOPLEVEL" ]
[ "$(unset PWD; /bin/pwd)" = "$TOPLEVEL" ]
)
'
}

TOPLEVEL="$(/bin/pwd)/repo"
TOPLEVEL="$(unset PWD; /bin/pwd)/repo"
mkdir -p repo/sub/dir
mv .git repo/
SUBDIRECTORY_OK=1
Expand Down

0 comments on commit dd6c136

Please sign in to comment.