From 48bb30331dc1139a7279d1665cfc76f14b5d0e67 Mon Sep 17 00:00:00 2001 From: Gerrit Pape <pape@smarden.org> Date: Mon, 26 Apr 2010 11:50:39 +0200 Subject: [PATCH 1/2] git-submodule.sh: properly initialize shell variables git-submodule inherits variables from the environment it is started in, expects the internal variables init= and recursive= to have an empty value, but doesn't initialize them appropriately. Thanks to the selftests, this can be reproduced through init=1 make test recursive=1 make test With this commit the variables are initialized, and the selftests succeed even if these variables have some values in the environment. The bug was discovered through the Debian autobuilders http://bugs.debian.org/569594 Signed-off-by: Gerrit Pape <pape@smarden.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> --- git-submodule.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/git-submodule.sh b/git-submodule.sh index e2082fd14..d3c583d01 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -21,6 +21,8 @@ command= branch= reference= cached= +recursive= +init= files= nofetch= update= From ed215b109fc0e352456ea2ef6a0f8375e28466d5 Mon Sep 17 00:00:00 2001 From: Michael J Gruber <git@drmicha.warpmail.net> Date: Thu, 29 Apr 2010 17:42:47 +0200 Subject: [PATCH 2/2] index-pack: fix trivial typo in usage string Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> --- builtin-index-pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin-index-pack.c b/builtin-index-pack.c index b4cf8c53e..03d0cd2f4 100644 --- a/builtin-index-pack.c +++ b/builtin-index-pack.c @@ -11,7 +11,7 @@ #include "exec_cmd.h" static const char index_pack_usage[] = -"git index-pack [-v] [-o <index-file>] [{ ---keep | --keep=<msg> }] [--strict] { <pack-file> | --stdin [--fix-thin] [<pack-file>] }"; +"git index-pack [-v] [-o <index-file>] [{ --keep | --keep=<msg> }] [--strict] { <pack-file> | --stdin [--fix-thin] [<pack-file>] }"; struct object_entry {