Skip to content

Commit

Permalink
name-rev --all: do not even attempt to describe non-commit object
Browse files Browse the repository at this point in the history
This even dates back to the very beginning of "git name-rev";
it does not make much sense to dump all objects in the repository
and label non-commits as "undefined".

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Nov 15, 2011
1 parent e923eae commit e8b14d7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion builtin-name-rev.c
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ int cmd_name_rev(int argc, const char **argv, const char *prefix)
max = get_max_object_index();
for (i = 0; i < max; i++) {
struct object *obj = get_indexed_object(i);
if (!obj)
if (!obj || obj->type != OBJ_COMMIT)
continue;
show_name(obj, NULL,
always, allow_undefined, data.name_only);
Expand Down

0 comments on commit e8b14d7

Please sign in to comment.