From 8358f1acd5f0cc7f886228f3266ab6940995fe1c Mon Sep 17 00:00:00 2001 From: Simon Ruderich Date: Mon, 3 Mar 2014 22:15:50 +0100 Subject: [PATCH 1/2] git-config: document interactive.singlekey requires Term::ReadKey Most distributions don't require Term::ReadKey as dependency, leaving the user to wonder why the setting doesn't work. Signed-off-by: Simon Ruderich Signed-off-by: Junio C Hamano --- Documentation/config.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/config.txt b/Documentation/config.txt index ab26963d6..7c3f67237 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -1629,7 +1629,7 @@ interactive.singlekey:: linkgit:git-add[1], linkgit:git-checkout[1], linkgit:git-commit[1], linkgit:git-reset[1], and linkgit:git-stash[1]. Note that this setting is silently ignored if portable keystroke input - is not available. + is not available; requires the Perl module Term::ReadKey. log.abbrevCommit:: If true, makes linkgit:git-log[1], linkgit:git-show[1], and From b294097bc64b056685c938c338f047be0c0771d8 Mon Sep 17 00:00:00 2001 From: Simon Ruderich Date: Mon, 3 Mar 2014 22:16:12 +0100 Subject: [PATCH 2/2] git-add--interactive: warn if module for interactive.singlekey is missing Suggested-by: Junio C Hamano Signed-off-by: Simon Ruderich Signed-off-by: Junio C Hamano --- git-add--interactive.perl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/git-add--interactive.perl b/git-add--interactive.perl index 24bb1ab99..d3bca1261 100755 --- a/git-add--interactive.perl +++ b/git-add--interactive.perl @@ -58,6 +58,9 @@ Term::ReadKey->import; $use_readkey = 1; }; + if (!$use_readkey) { + print STDERR "missing Term::ReadKey, disabling interactive.singlekey\n"; + } eval { require Term::Cap; my $termcap = Term::Cap->Tgetent;