Skip to content

Commit

Permalink
Git.pm: call tempfile from File::Temp as a regular function
Browse files Browse the repository at this point in the history
We call File::Temp's "tempfile" function as a class method, but it was
never designed to be called this way. Older versions seemed to
tolerate it, but as of File::Temp 0.23, it blows up like this:

  $ git svn fetch
  'tempfile' can't be called as a method at .../Git.pm line 1117.

Fix it by calling it as a regular function, just inside the File::Temp
namespace.

Signed-off-by: H. Merijn Brand <h.m.brand@xs4all.nl>
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
H. Merijn Brand authored and Junio C Hamano committed Apr 29, 2013
1 parent 1599999 commit eafc2dd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion perl/Git.pm
Original file line number Diff line number Diff line change
Expand Up @@ -1039,7 +1039,7 @@ sub _temp_cache {
$tmpdir = $self->repo_path();
}

($$temp_fd, $fname) = File::Temp->tempfile(
($$temp_fd, $fname) = File::Temp::tempfile(
'Git_XXXXXX', UNLINK => 1, DIR => $tmpdir,
) or throw Error::Simple("couldn't open new temp file");

Expand Down

0 comments on commit eafc2dd

Please sign in to comment.