Skip to content

Commit

Permalink
Make sure x86_64 GOT entry slot is always 8 bytes
Browse files Browse the repository at this point in the history
  • Loading branch information
H.J. Lu committed Mar 23, 2012
1 parent 3ff4252 commit 1532c7a
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 4 deletions.
6 changes: 6 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
2012-03-23 H.J. Lu <hongjiu.lu@intel.com>

* sysdeps/x86_64/dl-tlsdesc.h (tlsdesc): Use anonymous union
to pad to uint64_t for each field.
(dl_tls_index): Replace unsigned long with uint64_t.

2012-03-23 Daniel Jacobowitz <dmj@google.com>
Paul Pluzhnikov <ppluzhnikov@google.com>

Expand Down
18 changes: 14 additions & 4 deletions sysdeps/x86_64/dl-tlsdesc.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,24 @@
/* Type used to represent a TLS descriptor in the GOT. */
struct tlsdesc
{
ptrdiff_t (*entry)(struct tlsdesc *on_rax);
void *arg;
/* Anonymous union is used here to ensure that GOT entry slot is always
8 bytes for both x32 and x86-64. */
union
{
ptrdiff_t (*entry) (struct tlsdesc *on_rax);
uint64_t entry_slot;
};
union
{
void *arg;
uint64_t arg_slot;
};
};

typedef struct dl_tls_index
{
unsigned long int ti_module;
unsigned long int ti_offset;
uint64_t ti_module;
uint64_t ti_offset;
} tls_index;

/* Type used as the argument in a TLS descriptor for a symbol that
Expand Down

0 comments on commit 1532c7a

Please sign in to comment.