Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
* libio/iopopen.c (_IO_new_proc_open): Don't close child_std_end
	if one of proc_file_chain streams has that fileno.
	* stdio-common/Makefile (tests): Add tst-popen2.
	* stdio-common/tst-popen2.c: New test.
  • Loading branch information
Ulrich Drepper committed Jul 19, 2007
1 parent d8d7fee commit 4e42530
Show file tree
Hide file tree
Showing 3 changed files with 100 additions and 1 deletion.
7 changes: 7 additions & 0 deletions ChangeLog
@@ -1,3 +1,10 @@
2007-07-16 Jakub Jelinek <jakub@redhat.com>

* libio/iopopen.c (_IO_new_proc_open): Don't close child_std_end
if one of proc_file_chain streams has that fileno.
* stdio-common/Makefile (tests): Add tst-popen2.
* stdio-common/tst-popen2.c: New test.

2007-07-14 Jakub Jelinek <jakub@redhat.com>

* elf/ldconfig.c: Allow GPLv2 or any later version.
Expand Down
2 changes: 1 addition & 1 deletion stdio-common/Makefile
Expand Up @@ -55,7 +55,7 @@ tests := tstscanf test_rdwr test-popen tstgetln test-fseek \
tst-perror tst-sprintf tst-rndseek tst-fdopen tst-fphex bug14 bug15 \
tst-popen tst-unlockedio tst-fmemopen2 tst-put-error tst-fgets \
tst-fwrite bug16 bug17 tst-swscanf tst-sprintf2 bug18 bug18a \
bug19 bug19a
bug19 bug19a tst-popen2

test-srcs = tst-unbputc tst-printf

Expand Down
92 changes: 92 additions & 0 deletions stdio-common/tst-popen2.c
@@ -0,0 +1,92 @@
#include <stdio.h>
#include <string.h>
#include <unistd.h>

static int
do_test (void)
{
int fd = dup (fileno (stdout));
if (fd <= 1)
{
puts ("dup failed");
return 1;
}

FILE *f1 = fdopen (fd, "w");
if (f1 == NULL)
{
printf ("fdopen failed: %m\n");
return 1;
}

fclose (stdout);

FILE *f2 = popen ("echo test1", "r");
if (f2 == NULL)
{
fprintf (f1, "1st popen failed: %m\n");
return 1;
}
FILE *f3 = popen ("echo test2", "r");
if (f2 == NULL || f3 == NULL)
{
fprintf (f1, "2nd popen failed: %m\n");
return 1;
}

char *line = NULL;
size_t len = 0;
int result = 0;
if (getline (&line, &len, f2) != 6)
{
fputs ("could not read line from 1st popen\n", f1);
result = 1;
}
else if (strcmp (line, "test1\n") != 0)
{
fprintf (f1, "read \"%s\"\n", line);
result = 1;
}

if (getline (&line, &len, f2) != -1)
{
fputs ("second getline did not return -1\n", f1);
result = 1;
}

if (getline (&line, &len, f3) != 6)
{
fputs ("could not read line from 2nd popen\n", f1);
result = 1;
}
else if (strcmp (line, "test2\n") != 0)
{
fprintf (f1, "read \"%s\"\n", line);
result = 1;
}

if (getline (&line, &len, f3) != -1)
{
fputs ("second getline did not return -1\n", f1);
result = 1;
}

int ret = pclose (f2);
if (ret != 0)
{
fprintf (f1, "1st pclose returned %d\n", ret);
result = 1;
}

ret = pclose (f3);
if (ret != 0)
{
fprintf (f1, "2nd pclose returned %d\n", ret);
result = 1;
}

return result;
}

#define TEST_FUNCTION do_test ()
#include "../test-skeleton.c"

0 comments on commit 4e42530

Please sign in to comment.