From 6b06ac56cdfc9293908724e51e827534e97819aa Mon Sep 17 00:00:00 2001 From: Will Newton Date: Thu, 29 Aug 2013 20:10:26 +0100 Subject: [PATCH] ARM: Fix clone code when built for Thumb. The mov lr, pc instruction will lose the Thumb bit from the return address so use blx lr instead. ports/ChangeLog.arm: 2013-08-30 Will Newton [BZ #15909] * sysdeps/unix/sysv/linux/arm/clone.S (__clone): Use blx instead of mov lr, pc. --- NEWS | 2 +- ports/ChangeLog.arm | 6 ++++++ ports/sysdeps/unix/sysv/linux/arm/clone.S | 4 ++-- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index d3524ffa27..4fe4b63e23 100644 --- a/NEWS +++ b/NEWS @@ -10,7 +10,7 @@ Version 2.19 * The following bugs are resolved with this release: 14699, 15522, 15531, 15532, 15736, 15749, 15797, 15867, 15890, 15897, - 15905. + 15905, 15909. * CVE-2013-4237 The readdir_r function could write more than NAME_MAX bytes to the d_name member of struct dirent, or omit the terminating NUL diff --git a/ports/ChangeLog.arm b/ports/ChangeLog.arm index 8236f0f7d7..2a95834ce7 100644 --- a/ports/ChangeLog.arm +++ b/ports/ChangeLog.arm @@ -1,3 +1,9 @@ +2013-08-30 Will Newton + + [BZ #15909] + * sysdeps/unix/sysv/linux/arm/clone.S (__clone): Use blx + instead of mov lr, pc. + 2013-08-30 Will Newton * sysdeps/arm/armv6t2/strlen.S: New file. diff --git a/ports/sysdeps/unix/sysv/linux/arm/clone.S b/ports/sysdeps/unix/sysv/linux/arm/clone.S index ce9c2a5ba1..6e74fa702b 100644 --- a/ports/sysdeps/unix/sysv/linux/arm/clone.S +++ b/ports/sysdeps/unix/sysv/linux/arm/clone.S @@ -93,8 +93,8 @@ PSEUDO_END (__clone) mov lr, pc bx ip #else - mov lr, pc - ldr pc, [sp], #8 + ldr lr, [sp], #8 + blx lr #endif @ and we are done, passing the return value through r0