Skip to content

Commit

Permalink
Update.
Browse files Browse the repository at this point in the history
2004-10-30  Andreas Schwab  <schwab@suse.de>

	* sysdeps/unix/sysv/linux/waitid.c: Include <stddef.h> for NULL.

2004-10-30  Ulrich Drepper  <drepper@redhat.com>

	* malloc/malloc.c (_int_free): Use unique comments for the error
	cases.
  • Loading branch information
Ulrich Drepper committed Oct 30, 2004
1 parent 543fb0c commit 73f6403
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 7 deletions.
9 changes: 9 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
2004-10-30 Andreas Schwab <schwab@suse.de>

* sysdeps/unix/sysv/linux/waitid.c: Include <stddef.h> for NULL.

2004-10-30 Ulrich Drepper <drepper@redhat.com>

* malloc/malloc.c (_int_free): Use unique comments for the error
cases.

2004-10-28 Roland McGrath <roland@frob.com>

* sysdeps/mach/hurd/i386/tls.h (_hurd_tls_fork): Use i386_thread_state
Expand Down
26 changes: 19 additions & 7 deletions malloc/malloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -4198,6 +4198,8 @@ _int_free(mstate av, Void_t* mem)

/* free(0) has no effect */
if (mem != 0) {
const char *errstr = NULL;

p = mem2chunk(mem);
size = chunksize(p);

Expand All @@ -4207,7 +4209,9 @@ _int_free(mstate av, Void_t* mem)
here by accident or by "design" from some intruder. */
if (__builtin_expect ((uintptr_t) p > (uintptr_t) -size, 0))
{
malloc_printerr (check_action, "free(): invalid pointer", mem);
errstr = "free(): invalid pointer";
errout:
malloc_printerr (check_action, errstr, mem);
return;
}

Expand Down Expand Up @@ -4235,9 +4239,8 @@ _int_free(mstate av, Void_t* mem)
record we are going to add (i.e., double free). */
if (__builtin_expect (*fb == p, 0))
{
double_free:
malloc_printerr (check_action, "double free or corruption", mem);
return;
errstr = "double free or corruption (fasttop)";
goto errout;
}
p->fd = *fb;
*fb = p;
Expand All @@ -4253,15 +4256,24 @@ _int_free(mstate av, Void_t* mem)
/* Lightweight tests: check whether the block is already the
top block. */
if (__builtin_expect (p == av->top, 0))
goto double_free;
{
errstr = "double free or corruption (top)";
goto errout;
}
/* Or whether the next chunk is beyond the boundaries of the arena. */
if (__builtin_expect (contiguous (av)
&& (char *) nextchunk
>= ((char *) av->top + chunksize(av->top)), 0))
goto double_free;
{
errstr = "double free or corruption (out)";
goto errout;
}
/* Or whether the block is actually not marked used. */
if (__builtin_expect (!prev_inuse(nextchunk), 0))
goto double_free;
{
errstr = "double free or corruption (!prev)";
goto errout;
}

nextsize = chunksize(nextchunk);
assert(nextsize > 0);
Expand Down
1 change: 1 addition & 0 deletions sysdeps/unix/sysv/linux/waitid.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307 USA. */

#include <stddef.h>
#include <errno.h>
#include <sys/wait.h>
#include <kernel-features.h>
Expand Down

0 comments on commit 73f6403

Please sign in to comment.