From ed159672eb3cd650a32b7e5cb4d5ec1fe0e63802 Mon Sep 17 00:00:00 2001 From: Florian Weimer Date: Fri, 24 Apr 2015 11:10:24 +0200 Subject: [PATCH] Do not build with -Winline -Winline causes architecture- and optimization-dependent build failures due to -Werror. -Winline warns about inlining decisions based on branch hints, in effect preventing the use of inline functions in header files (because they might be called on unlikely branches, leading to a decision not to inline). The option was apparently added to the glibc build at a time when GCC did not support the always_inline attribute. With current GCC versions, inlining failure for functions declared always_inline will receive a warning under -Wattributes, which is enabled by default, so -Winline appears unnecessary. --- ChangeLog | 4 ++++ Makeconfig | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 97fb9feb08..f515a2a43e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2015-04-24 Florian Weimer + + * Makeconfig (+gccwarn): Remove -Winline. + 2015-04-24 Stefan Liebler * sysdeps/s390/fpu/libm-test-upls: Regenerate. diff --git a/Makeconfig b/Makeconfig index dc7f2088eb..77752c0bb4 100644 --- a/Makeconfig +++ b/Makeconfig @@ -739,9 +739,9 @@ endif # Extra flags to pass to GCC. ifeq ($(all-warnings),yes) -+gccwarn := -Wall -Wwrite-strings -Winline -Wcast-qual -Wbad-function-cast -Wmissing-noreturn -Wmissing-prototypes -Wmissing-declarations -Wcomment -Wcomments -Wtrigraphs -Wsign-compare -Wfloat-equal -Wmultichar ++gccwarn := -Wall -Wwrite-strings -Wcast-qual -Wbad-function-cast -Wmissing-noreturn -Wmissing-prototypes -Wmissing-declarations -Wcomment -Wcomments -Wtrigraphs -Wsign-compare -Wfloat-equal -Wmultichar else -+gccwarn := -Wall -Wwrite-strings -Winline ++gccwarn := -Wall -Wwrite-strings endif +gccwarn += -Wundef ifeq ($(enable-werror),yes)