From 025ea30a3dcc692b9ae429f32acccf0dbce98635 Mon Sep 17 00:00:00 2001 From: Ben Greear Date: Wed, 1 Jun 2011 07:18:52 +0000 Subject: [PATCH] --- yaml --- r: 255339 b: refs/heads/master c: 160ff18a07f3a505d452dcced8e45ecdd0a85506 h: refs/heads/master i: 255337: 707355cfeb7fdaf5ef3a68a768b7876fd70de835 255335: 6d3a471cb5e5507e61f921ae5e4dfe37d1e59e83 v: v3 --- [refs] | 2 +- trunk/net/packet/af_packet.c | 14 +++++++++----- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/[refs] b/[refs] index 83117f8eda75..ee5e14e2505f 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: e990b37b906b6137d353ef2a918e15e5763d70ec +refs/heads/master: 160ff18a07f3a505d452dcced8e45ecdd0a85506 diff --git a/trunk/net/packet/af_packet.c b/trunk/net/packet/af_packet.c index ba248d93399a..636b75c15a63 100644 --- a/trunk/net/packet/af_packet.c +++ b/trunk/net/packet/af_packet.c @@ -1342,6 +1342,10 @@ static int packet_release(struct socket *sock) __dev_remove_pack(&po->prot_hook); __sock_put(sk); } + if (po->prot_hook.dev) { + dev_put(po->prot_hook.dev); + po->prot_hook.dev = NULL; + } spin_unlock(&po->bind_lock); packet_flush_mclist(sk); @@ -1395,6 +1399,8 @@ static int packet_do_bind(struct sock *sk, struct net_device *dev, __be16 protoc po->num = protocol; po->prot_hook.type = protocol; + if (po->prot_hook.dev) + dev_put(po->prot_hook.dev); po->prot_hook.dev = dev; po->ifindex = dev ? dev->ifindex : 0; @@ -1439,10 +1445,8 @@ static int packet_bind_spkt(struct socket *sock, struct sockaddr *uaddr, strlcpy(name, uaddr->sa_data, sizeof(name)); dev = dev_get_by_name(sock_net(sk), name); - if (dev) { + if (dev) err = packet_do_bind(sk, dev, pkt_sk(sk)->num); - dev_put(dev); - } return err; } @@ -1470,8 +1474,6 @@ static int packet_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len goto out; } err = packet_do_bind(sk, dev, sll->sll_protocol ? : pkt_sk(sk)->num); - if (dev) - dev_put(dev); out: return err; @@ -2240,6 +2242,8 @@ static int packet_notifier(struct notifier_block *this, unsigned long msg, void } if (msg == NETDEV_UNREGISTER) { po->ifindex = -1; + if (po->prot_hook.dev) + dev_put(po->prot_hook.dev); po->prot_hook.dev = NULL; } spin_unlock(&po->bind_lock);