From 02690120c82ed6224af1d6843efb8f157d5a8be4 Mon Sep 17 00:00:00 2001 From: Darren Hart Date: Thu, 12 Mar 2009 00:55:46 -0700 Subject: [PATCH] --- yaml --- r: 137595 b: refs/heads/master c: de87fcc124a5d4a171aa32707b3265608ebda6e7 h: refs/heads/master i: 137593: 276e1c14d1d5071768452d6cba380eae4b289eef 137591: fb894b181cde3fe687cc426581899a5f3d398713 v: v3 --- [refs] | 2 +- trunk/kernel/futex.c | 16 +++++++++++----- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/[refs] b/[refs] index e0324f943e6b..19bf1f4a2514 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: b2d0994b1301fc3a6a89e1889578dac9227840e3 +refs/heads/master: de87fcc124a5d4a171aa32707b3265608ebda6e7 diff --git a/trunk/kernel/futex.c b/trunk/kernel/futex.c index e6a4d72bca3d..4000454e4d83 100644 --- a/trunk/kernel/futex.c +++ b/trunk/kernel/futex.c @@ -802,8 +802,10 @@ futex_wake_op(u32 __user *uaddr1, int fshared, u32 __user *uaddr2, ret = get_user(dummy, uaddr2); if (ret) - return ret; + goto out_put_keys; + put_futex_key(fshared, &key2); + put_futex_key(fshared, &key1); goto retryfull; } @@ -878,6 +880,9 @@ static int futex_requeue(u32 __user *uaddr1, int fshared, u32 __user *uaddr2, if (hb1 != hb2) spin_unlock(&hb2->lock); + put_futex_key(fshared, &key2); + put_futex_key(fshared, &key1); + ret = get_user(curval, uaddr1); if (!ret) @@ -1453,6 +1458,7 @@ static int futex_lock_pi(u32 __user *uaddr, int fshared, * exit to complete. */ queue_unlock(&q, hb); + put_futex_key(fshared, &q.key); cond_resched(); goto retry; @@ -1595,13 +1601,12 @@ static int futex_lock_pi(u32 __user *uaddr, int fshared, ret = get_user(uval, uaddr); if (!ret) - goto retry; + goto retry_unlocked; - if (to) - destroy_hrtimer_on_stack(&to->timer); - return ret; + goto out_put_key; } + /* * Userspace attempted a TID -> 0 atomic transition, and failed. * This is the in-kernel slowpath: we look up the PI state (if any), @@ -1705,6 +1710,7 @@ static int futex_unlock_pi(u32 __user *uaddr, int fshared) } ret = get_user(uval, uaddr); + put_futex_key(fshared, &key); if (!ret) goto retry;