From 04d021f32f63a859a27df2a783530a06655c9916 Mon Sep 17 00:00:00 2001 From: Joe Perches Date: Mon, 17 Dec 2012 16:02:07 -0800 Subject: [PATCH] --- yaml --- r: 346425 b: refs/heads/master c: 323c1260ba2c4b5c4b2a1e9ab6657cde54ccf554 h: refs/heads/master i: 346423: aea9747cb584b2f9ecd210d0dc8787b7b63b0891 v: v3 --- [refs] | 2 +- trunk/scripts/checkpatch.pl | 19 +++++++++++++------ 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/[refs] b/[refs] index f5e6ac3c95d3..d2ac23e22538 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 74349bccedb3e34b4f1fd9c7efd2dda7905e3335 +refs/heads/master: 323c1260ba2c4b5c4b2a1e9ab6657cde54ccf554 diff --git a/trunk/scripts/checkpatch.pl b/trunk/scripts/checkpatch.pl index 9de3a69260e1..1d6e4c541370 100755 --- a/trunk/scripts/checkpatch.pl +++ b/trunk/scripts/checkpatch.pl @@ -1398,6 +1398,8 @@ sub process { my %suppress_export; my $suppress_statement = 0; + my %camelcase = (); + # Pre-scan the patch sanitizing the lines. # Pre-scan the patch looking for any __setup documentation. # @@ -2905,12 +2907,17 @@ sub process { } } -#studly caps, commented out until figure out how to distinguish between use of existing and adding new -# if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) { -# print "No studly caps, use _\n"; -# print "$herecurr"; -# $clean = 0; -# } +#CamelCase + while ($line =~ m{($Constant|$Lval)}g) { + my $var = $1; + if ($var !~ /$Constant/ && + $var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ && + !defined $camelcase{$var}) { + $camelcase{$var} = 1; + WARN("CAMELCASE", + "Avoid CamelCase: <$var>\n" . $herecurr); + } + } #no spaces allowed after \ in define if ($line=~/\#\s*define.*\\\s$/) {