From 2095bc0da2a11af6237febe0cea14bf732bc14b0 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 15 Apr 2009 16:52:16 -0700 Subject: [PATCH] --- yaml --- r: 143670 b: refs/heads/master c: 1a92e82a86556727da1626393f2a6becf7e62f39 h: refs/heads/master v: v3 --- [refs] | 2 +- trunk/drivers/staging/slicoss/README | 31 +++++++++++++++++++++++++++- 2 files changed, 31 insertions(+), 2 deletions(-) diff --git a/[refs] b/[refs] index a96284ec001a..f55d60bf0552 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 5672487d29bd6a3cb0bff941d4f4535ccacc41ed +refs/heads/master: 1a92e82a86556727da1626393f2a6becf7e62f39 diff --git a/trunk/drivers/staging/slicoss/README b/trunk/drivers/staging/slicoss/README index 2d5b1127ce51..70f49099c065 100644 --- a/trunk/drivers/staging/slicoss/README +++ b/trunk/drivers/staging/slicoss/README @@ -10,7 +10,36 @@ TODO: - move firmware loading to request_firmware() - remove direct memory access of structures - any remaining sparse and checkpatch.pl warnings - - any netdev recommended changes + + - use net_device_ops + - use dev->stats rather than adapter->stats + - don't cast netdev_priv it is already void + - use compare_ether_addr + - GET RID OF MACROS + - work on all architectures + - without CONFIG_X86_64 confusion + - do 64 bit correctly + - don't depend on order of union + - get rid of ASSERT(), use BUG() instead but only where necessary + looks like most aren't really useful + - no new SIOCDEVPRIVATE ioctl allowed + - don't use module_param for configuring interrupt mitigation + use ethtool instead + - reorder code to elminate use of forward declarations + - don't keep private linked list of drivers. + - remove all the gratiutous debug infrastructure + - use PCI_DEVICE() + - do ethtool correctly using ethtool_ops + - NAPI? + - wasted overhead of extra stats + - state variables for things that are + easily availble and shouldn't be kept in card structure, cardnum, ... + slotnumber, events, ... + - get rid of slic_spinlock wrapper + - volatile == bad design => bad code + - locking too fine grained, not designed just throw more locks + at problem + Please send patches to: Greg Kroah-Hartman