From 249a163d819852f877e858b1c1c95f4b5f6bb7b8 Mon Sep 17 00:00:00 2001
From: Mike Christie <michaelc@cs.wisc.edu>
Date: Thu, 13 Dec 2007 12:43:42 -0600
Subject: [PATCH] --- yaml --- r: 77075 b: refs/heads/master c:
 df93ffcd748ce41e7b716c3056ae511939bb745e h: refs/heads/master i:   77073:
 c0a0d6c38e54e25f2453d4034ee078e65a8afd8d   77071:
 ec7d3220eb081a0525680bf95907138dfd067371 v: v3

---
 [refs]                         | 2 +-
 trunk/drivers/scsi/iscsi_tcp.c | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/[refs] b/[refs]
index 603edf4b8108..b846bcded726 100644
--- a/[refs]
+++ b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 118365721768f29d74718a59895ed7bd3c10b68e
+refs/heads/master: df93ffcd748ce41e7b716c3056ae511939bb745e
diff --git a/trunk/drivers/scsi/iscsi_tcp.c b/trunk/drivers/scsi/iscsi_tcp.c
index edebdf27af9b..e5be5fd4ef58 100644
--- a/trunk/drivers/scsi/iscsi_tcp.c
+++ b/trunk/drivers/scsi/iscsi_tcp.c
@@ -1774,12 +1774,12 @@ iscsi_conn_set_param(struct iscsi_cls_conn *cls_conn, enum iscsi_param param,
 		break;
 	case ISCSI_PARAM_MAX_R2T:
 		sscanf(buf, "%d", &value);
-		if (session->max_r2t == roundup_pow_of_two(value))
+		if (value <= 0 || !is_power_of_2(value))
+			return -EINVAL;
+		if (session->max_r2t == value)
 			break;
 		iscsi_r2tpool_free(session);
 		iscsi_set_param(cls_conn, param, buf, buflen);
-		if (session->max_r2t & (session->max_r2t - 1))
-			session->max_r2t = roundup_pow_of_two(session->max_r2t);
 		if (iscsi_r2tpool_alloc(session))
 			return -ENOMEM;
 		break;