From 2e7e0537f43ff7565f68ebbf345a4ec6bfd86a6d Mon Sep 17 00:00:00 2001 From: Alan Cox Date: Wed, 19 Sep 2012 15:46:06 +0100 Subject: [PATCH] --- yaml --- r: 328021 b: refs/heads/master c: 4308fc58dceda40fac8a8d9c05b7cfba0a6bbed3 h: refs/heads/master i: 328019: 41635654f9d517b9b5847a7c5f5e37c95f2b9bdc v: v3 --- [refs] | 2 +- trunk/net/ipv4/tcp_minisocks.c | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/[refs] b/[refs] index e09f64cf9a37..2f53c96f5b61 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: bb68b64724a4fd6b93d83b39aeffa4aadb2562fc +refs/heads/master: 4308fc58dceda40fac8a8d9c05b7cfba0a6bbed3 diff --git a/trunk/net/ipv4/tcp_minisocks.c b/trunk/net/ipv4/tcp_minisocks.c index e965319d610b..5792577b5bc5 100644 --- a/trunk/net/ipv4/tcp_minisocks.c +++ b/trunk/net/ipv4/tcp_minisocks.c @@ -85,6 +85,8 @@ static bool tcp_in_window(u32 seq, u32 end_seq, u32 s_win, u32 e_win) * spinlock it. I do not want! Well, probability of misbehaviour * is ridiculously low and, seems, we could use some mb() tricks * to avoid misread sequence numbers, states etc. --ANK + * + * We don't need to initialize tmp_out.sack_ok as we don't use the results */ enum tcp_tw_status tcp_timewait_state_process(struct inet_timewait_sock *tw, struct sk_buff *skb, @@ -522,6 +524,8 @@ EXPORT_SYMBOL(tcp_create_openreq_child); * * XXX (TFO) - The current impl contains a special check for ack * validation and inside tcp_v4_reqsk_send_ack(). Can we do better? + * + * We don't need to initialize tmp_opt.sack_ok as we don't use the results */ struct sock *tcp_check_req(struct sock *sk, struct sk_buff *skb,