diff --git a/[refs] b/[refs] index 7dd34f934c35..18c84da146c6 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: f72dd56690aba26fc87fc64e98dd4cc66f27122c +refs/heads/master: b96e4abaaeda62b5292026a9deaacb4066431ac7 diff --git a/trunk/drivers/infiniband/ulp/ipoib/ipoib.h b/trunk/drivers/infiniband/ulp/ipoib/ipoib.h index eb71aaa26a9a..07ca6fd5546b 100644 --- a/trunk/drivers/infiniband/ulp/ipoib/ipoib.h +++ b/trunk/drivers/infiniband/ulp/ipoib/ipoib.h @@ -117,8 +117,6 @@ enum { #define IPOIB_OP_CM (0) #endif -#define IPOIB_QPN_MASK ((__force u32) cpu_to_be32(0xFFFFFF)) - /* structs */ struct ipoib_header { @@ -762,6 +760,4 @@ extern int ipoib_debug_level; #define IPOIB_QPN(ha) (be32_to_cpup((__be32 *) ha) & 0xffffff) -extern const char ipoib_driver_version[]; - #endif /* _IPOIB_H */ diff --git a/trunk/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c b/trunk/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c index c4b3940845e6..29bc7b5724ac 100644 --- a/trunk/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c +++ b/trunk/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c @@ -39,24 +39,7 @@ static void ipoib_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo) { - struct ipoib_dev_priv *priv = netdev_priv(netdev); - struct ib_device_attr *attr; - - attr = kmalloc(sizeof(*attr), GFP_KERNEL); - if (attr && !ib_query_device(priv->ca, attr)) - snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version), - "%d.%d.%d", (int)(attr->fw_ver >> 32), - (int)(attr->fw_ver >> 16) & 0xffff, - (int)attr->fw_ver & 0xffff); - kfree(attr); - - strlcpy(drvinfo->bus_info, dev_name(priv->ca->dma_device), - sizeof(drvinfo->bus_info)); - - strlcpy(drvinfo->version, ipoib_driver_version, - sizeof(drvinfo->version)); - - strlcpy(drvinfo->driver, "ib_ipoib", sizeof(drvinfo->driver)); + strncpy(drvinfo->driver, "ipoib", sizeof(drvinfo->driver) - 1); } static int ipoib_get_coalesce(struct net_device *dev, diff --git a/trunk/drivers/infiniband/ulp/ipoib/ipoib_main.c b/trunk/drivers/infiniband/ulp/ipoib/ipoib_main.c index 8534afd04e7c..6fdc9e78da0d 100644 --- a/trunk/drivers/infiniband/ulp/ipoib/ipoib_main.c +++ b/trunk/drivers/infiniband/ulp/ipoib/ipoib_main.c @@ -49,14 +49,9 @@ #include #include -#define DRV_VERSION "1.0.0" - -const char ipoib_driver_version[] = DRV_VERSION; - MODULE_AUTHOR("Roland Dreier"); MODULE_DESCRIPTION("IP-over-InfiniBand net driver"); MODULE_LICENSE("Dual BSD/GPL"); -MODULE_VERSION(DRV_VERSION); int ipoib_sendq_size __read_mostly = IPOIB_TX_RING_SIZE; int ipoib_recvq_size __read_mostly = IPOIB_RX_RING_SIZE; @@ -510,9 +505,6 @@ static void path_rec_completion(int status, spin_unlock_irqrestore(&priv->lock, flags); - if (IS_ERR_OR_NULL(ah)) - ipoib_del_neighs_by_gid(dev, path->pathrec.dgid.raw); - if (old_ah) ipoib_put_ah(old_ah); @@ -852,10 +844,10 @@ static u32 ipoib_addr_hash(struct ipoib_neigh_hash *htbl, u8 *daddr) * different subnets. */ /* qpn octets[1:4) & port GUID octets[12:20) */ - u32 *d32 = (u32 *) daddr; + u32 *daddr_32 = (u32 *) daddr; u32 hv; - hv = jhash_3words(d32[3], d32[4], IPOIB_QPN_MASK & d32[0], 0); + hv = jhash_3words(daddr_32[3], daddr_32[4], 0xFFFFFF & daddr_32[0], 0); return hv & htbl->mask; } @@ -1696,8 +1688,6 @@ static void ipoib_remove_one(struct ib_device *device) return; dev_list = ib_get_client_data(device, &ipoib_client); - if (!dev_list) - return; list_for_each_entry_safe(priv, tmp, dev_list, list) { ib_unregister_event_handler(&priv->event_handler); diff --git a/trunk/drivers/infiniband/ulp/iser/iscsi_iser.h b/trunk/drivers/infiniband/ulp/iser/iscsi_iser.h index ef7d3be46c31..5babdb35bda7 100644 --- a/trunk/drivers/infiniband/ulp/iser/iscsi_iser.h +++ b/trunk/drivers/infiniband/ulp/iser/iscsi_iser.h @@ -94,7 +94,7 @@ /* support up to 512KB in one RDMA */ #define ISCSI_ISER_SG_TABLESIZE (0x80000 >> SHIFT_4K) -#define ISER_DEF_CMD_PER_LUN 128 +#define ISER_DEF_CMD_PER_LUN ISCSI_DEF_XMIT_CMDS_MAX /* QP settings */ /* Maximal bounds on received asynchronous PDUs */