From 32c57971c242a1960af0c556f4fd197a67da898f Mon Sep 17 00:00:00 2001 From: Avi Kivity Date: Thu, 24 Jun 2010 14:10:09 +0300 Subject: [PATCH] --- yaml --- r: 202375 b: refs/heads/master c: cf3e3d3e19868ca01da163200bbfc687523df0fc h: refs/heads/master i: 202373: 47f51fd53166aaf1311e899f17f189f388e47fb1 202371: 8eaed5ef0ec1c8d6a6d36f5b5c3a09bbe949cc51 202367: bb55bde4e6b510ecfa9b04e200e68492a0d70faf v: v3 --- [refs] | 2 +- trunk/Documentation/kvm/review-checklist.txt | 38 ++++++++++++++++++++ 2 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 trunk/Documentation/kvm/review-checklist.txt diff --git a/[refs] b/[refs] index 0cea84c76e08..908849601336 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 3e0075094734de122e4cb09f930fa853a3c59f09 +refs/heads/master: cf3e3d3e19868ca01da163200bbfc687523df0fc diff --git a/trunk/Documentation/kvm/review-checklist.txt b/trunk/Documentation/kvm/review-checklist.txt new file mode 100644 index 000000000000..730475ae1b8d --- /dev/null +++ b/trunk/Documentation/kvm/review-checklist.txt @@ -0,0 +1,38 @@ +Review checklist for kvm patches +================================ + +1. The patch must follow Documentation/CodingStyle and + Documentation/SubmittingPatches. + +2. Patches should be against kvm.git master branch. + +3. If the patch introduces or modifies a new userspace API: + - the API must be documented in Documentation/kvm/api.txt + - the API must be discoverable using KVM_CHECK_EXTENSION + +4. New state must include support for save/restore. + +5. New features must default to off (userspace should explicitly request them). + Performance improvements can and should default to on. + +6. New cpu features should be exposed via KVM_GET_SUPPORTED_CPUID2 + +7. Emulator changes should be accompanied by unit tests for qemu-kvm.git + kvm/test directory. + +8. Changes should be vendor neutral when possible. Changes to common code + are better than duplicating changes to vendor code. + +9. Similarly, prefer changes to arch independent code than to arch dependent + code. + +10. User/kernel interfaces and guest/host interfaces must be 64-bit clean + (all variables and sizes naturally aligned on 64-bit; use specific types + only - u64 rather than ulong). + +11. New guest visible features must either be documented in a hardware manual + or be accompanied by documentation. + +12. Features must be robust against reset and kexec - for example, shared + host/guest memory must be unshared to prevent the host from writing to + guest memory that the guest has not reserved for this purpose.