From 38a4cc6ca016f6dbcb90880270f770a6c32f0bca Mon Sep 17 00:00:00 2001 From: "J. Bruce Fields" Date: Fri, 15 Jul 2011 19:09:08 -0400 Subject: [PATCH] --- yaml --- r: 260865 b: refs/heads/master c: 674e405b8b3310702fd43d314f5f432ec2cb9980 h: refs/heads/master i: 260863: a1ab4332b0dce01ed582d44bb043b732beaf4e0d v: v3 --- [refs] | 2 +- trunk/fs/nfs/unlink.c | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/[refs] b/[refs] index 3725bfa220b1..6dee7ebc76ad 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 94b134ac8e9965309e70684b504c53bca36338b4 +refs/heads/master: 674e405b8b3310702fd43d314f5f432ec2cb9980 diff --git a/trunk/fs/nfs/unlink.c b/trunk/fs/nfs/unlink.c index 8d6864c2a5fa..981298ce5124 100644 --- a/trunk/fs/nfs/unlink.c +++ b/trunk/fs/nfs/unlink.c @@ -501,6 +501,14 @@ nfs_async_rename(struct inode *old_dir, struct inode *new_dir, * and only performs the unlink once the last reference to it is put. * * The final cleanup is done during dentry_iput. + * + * (Note: NFSv4 is stateful, and has opens, so in theory an NFSv4 server + * could take responsibility for keeping open files referenced. The server + * would also need to ensure that opened-but-deleted files were kept over + * reboots. However, we may not assume a server does so. (RFC 5661 + * does provide an OPEN4_RESULT_PRESERVE_UNLINKED flag that a server can + * use to advertise that it does this; some day we may take advantage of + * it.)) */ int nfs_sillyrename(struct inode *dir, struct dentry *dentry)