From 3a86d2fc63c3b85606be6e4d320b3fa1cde1cedd Mon Sep 17 00:00:00 2001 From: Tejun Heo Date: Thu, 12 Feb 2009 10:34:32 +0900 Subject: [PATCH] --- yaml --- r: 131431 b: refs/heads/master c: 7dac745b8e367c99175b8f0d014d996f0e5ed9e5 h: refs/heads/master i: 131429: 246b1141a384506eb735d6b3d5354adb435b5eaf 131427: b75daa32dbbc6b85db0fdf50e9afd0b47c58592b 131423: 5114e0b42c31d3e6d5cc12dd90f38cb4026f5102 v: v3 --- [refs] | 2 +- trunk/drivers/ata/sata_nv.c | 14 ++++++++------ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/[refs] b/[refs] index 4c66461da45f..a7b34aca7590 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: d1b3525b4126d7acad0493b62642b80b71442661 +refs/heads/master: 7dac745b8e367c99175b8f0d014d996f0e5ed9e5 diff --git a/trunk/drivers/ata/sata_nv.c b/trunk/drivers/ata/sata_nv.c index 444af0415ca1..55a8eed3f3a3 100644 --- a/trunk/drivers/ata/sata_nv.c +++ b/trunk/drivers/ata/sata_nv.c @@ -421,19 +421,21 @@ static struct ata_port_operations nv_generic_ops = { .hardreset = ATA_OP_NULL, }; -/* OSDL bz3352 reports that nf2/3 controllers can't determine device - * signature reliably. Also, the following thread reports detection - * failure on cold boot with the standard debouncing timing. +/* nf2 is ripe with hardreset related problems. + * + * kernel bz#3352 reports nf2/3 controllers can't determine device + * signature reliably. The following thread reports detection failure + * on cold boot with the standard debouncing timing. * * http://thread.gmane.org/gmane.linux.ide/34098 * - * Debounce with hotplug timing and request follow-up SRST. + * And bz#12176 reports that hardreset simply doesn't work on nf2. + * Give up on it and just don't do hardreset. */ static struct ata_port_operations nv_nf2_ops = { - .inherits = &nv_common_ops, + .inherits = &nv_generic_ops, .freeze = nv_nf2_freeze, .thaw = nv_nf2_thaw, - .hardreset = nv_noclassify_hardreset, }; /* For initial probing after boot and hot plugging, hardreset mostly