From 4a33e997c4dc3cd7e340898bcda07aca1f94243d Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Thu, 5 May 2005 16:16:02 -0700 Subject: [PATCH] --- yaml --- r: 1023 b: refs/heads/master c: d17d7fa44dbe1f12031773e27eda9e939024a037 h: refs/heads/master i: 1021: a3e077c91c93f4b54df6b99ff6774897fadb799b 1019: ca1e99ad09d706870064fb4eb96ad726117d8179 1015: a8c16742de5688d2e4ca3d079c1ce627fedb9588 1007: db6455f033d14f9be744fd5f99ad5fea640161bc 991: ef4afc64646180fd5e7c00c12d32dca890647d23 959: e340247e2378d87e79914efa64f045f71e106054 895: 2daf7c485a483665c9e7214a6fc7fc8a617729c0 767: 5686ca0dc6cc523e8fabb3ca70e570b027c6d4b0 511: a4ccb142a09ad69976cf727ba97be442de09b822 v: v3 --- [refs] | 2 +- trunk/fs/ext3/inode.c | 46 ------------------------------------- trunk/fs/mpage.c | 12 +--------- trunk/include/linux/mpage.h | 3 --- 4 files changed, 2 insertions(+), 61 deletions(-) diff --git a/[refs] b/[refs] index 02c578c8818e..06cfe2adf32b 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: ecffdde68ebefa1aa24411a91b12ae649f71f71c +refs/heads/master: d17d7fa44dbe1f12031773e27eda9e939024a037 diff --git a/trunk/fs/ext3/inode.c b/trunk/fs/ext3/inode.c index ea5888688f94..0d5fa73b18dc 100644 --- a/trunk/fs/ext3/inode.c +++ b/trunk/fs/ext3/inode.c @@ -844,12 +844,6 @@ ext3_direct_io_get_blocks(struct inode *inode, sector_t iblock, return ret; } -static int ext3_writepages_get_block(struct inode *inode, sector_t iblock, - struct buffer_head *bh, int create) -{ - return ext3_direct_io_get_blocks(inode, iblock, 1, bh, create); -} - /* * `handle' can be NULL if create is zero */ @@ -1323,45 +1317,6 @@ static int ext3_ordered_writepage(struct page *page, return ret; } -static int -ext3_writeback_writepage_helper(struct page *page, - struct writeback_control *wbc) -{ - return block_write_full_page(page, ext3_get_block, wbc); -} - -static int -ext3_writeback_writepages(struct address_space *mapping, - struct writeback_control *wbc) -{ - struct inode *inode = mapping->host; - handle_t *handle = NULL; - int err, ret = 0; - - if (!mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) - return ret; - - handle = ext3_journal_start(inode, ext3_writepage_trans_blocks(inode)); - if (IS_ERR(handle)) { - ret = PTR_ERR(handle); - return ret; - } - - ret = __mpage_writepages(mapping, wbc, ext3_writepages_get_block, - ext3_writeback_writepage_helper); - - /* - * Need to reaquire the handle since ext3_writepages_get_block() - * can restart the handle - */ - handle = journal_current_handle(); - - err = ext3_journal_stop(handle); - if (!ret) - ret = err; - return ret; -} - static int ext3_writeback_writepage(struct page *page, struct writeback_control *wbc) { @@ -1599,7 +1554,6 @@ static struct address_space_operations ext3_writeback_aops = { .readpage = ext3_readpage, .readpages = ext3_readpages, .writepage = ext3_writeback_writepage, - .writepages = ext3_writeback_writepages, .sync_page = block_sync_page, .prepare_write = ext3_prepare_write, .commit_write = ext3_writeback_commit_write, diff --git a/trunk/fs/mpage.c b/trunk/fs/mpage.c index 32c7c8fcfce7..68db5256a727 100644 --- a/trunk/fs/mpage.c +++ b/trunk/fs/mpage.c @@ -626,15 +626,6 @@ __mpage_writepage(struct bio *bio, struct page *page, get_block_t get_block, int mpage_writepages(struct address_space *mapping, struct writeback_control *wbc, get_block_t get_block) -{ - return __mpage_writepages(mapping, wbc, get_block, - mapping->a_ops->writepage); -} - -int -__mpage_writepages(struct address_space *mapping, - struct writeback_control *wbc, get_block_t get_block, - writepage_t writepage_fn) { struct backing_dev_info *bdi = mapping->backing_dev_info; struct bio *bio = NULL; @@ -725,7 +716,7 @@ __mpage_writepages(struct address_space *mapping, } else { bio = __mpage_writepage(bio, page, get_block, &last_block_in_bio, &ret, wbc, - writepage_fn); + page->mapping->a_ops->writepage); } if (unlikely(ret == WRITEPAGE_ACTIVATE)) unlock_page(page); @@ -755,7 +746,6 @@ __mpage_writepages(struct address_space *mapping, return ret; } EXPORT_SYMBOL(mpage_writepages); -EXPORT_SYMBOL(__mpage_writepages); int mpage_writepage(struct page *page, get_block_t get_block, struct writeback_control *wbc) diff --git a/trunk/include/linux/mpage.h b/trunk/include/linux/mpage.h index dea1b0083661..3ca880463c47 100644 --- a/trunk/include/linux/mpage.h +++ b/trunk/include/linux/mpage.h @@ -20,9 +20,6 @@ int mpage_writepages(struct address_space *mapping, struct writeback_control *wbc, get_block_t get_block); int mpage_writepage(struct page *page, get_block_t *get_block, struct writeback_control *wbc); -int __mpage_writepages(struct address_space *mapping, - struct writeback_control *wbc, get_block_t get_block, - writepage_t writepage); static inline int generic_writepages(struct address_space *mapping, struct writeback_control *wbc)