From 50763536e54a4cccc40db81a0b96999a4617c3b1 Mon Sep 17 00:00:00 2001
From: Thomas Sujith <sujith.thomas@intel.com>
Date: Fri, 15 Feb 2008 01:01:52 -0500
Subject: [PATCH] --- yaml --- r: 86114 b: refs/heads/master c:
 19b36780ee7ddeb5080e3f1f858a83c4824f1fdc h: refs/heads/master v: v3

---
 [refs]                   |  2 +-
 trunk/drivers/acpi/fan.c | 30 ++++++++++++++++++------------
 2 files changed, 19 insertions(+), 13 deletions(-)

diff --git a/[refs] b/[refs]
index b34c30e698b9..f12b9d2a124c 100644
--- a/[refs]
+++ b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 3e6fda5c1159823fc02463eceb564c8bfc0e7a0e
+refs/heads/master: 19b36780ee7ddeb5080e3f1f858a83c4824f1fdc
diff --git a/trunk/drivers/acpi/fan.c b/trunk/drivers/acpi/fan.c
index 48cb705b274a..c8e3cba423ef 100644
--- a/trunk/drivers/acpi/fan.c
+++ b/trunk/drivers/acpi/fan.c
@@ -256,22 +256,28 @@ static int acpi_fan_add(struct acpi_device *device)
 
 	cdev = thermal_cooling_device_register("Fan", device,
 						&fan_cooling_ops);
-	if (cdev)
+	if (IS_ERR(cdev)) {
+		result = PTR_ERR(cdev);
+		goto end;
+	}
+	if (cdev) {
 		printk(KERN_INFO PREFIX
 			"%s is registered as cooling_device%d\n",
 			device->dev.bus_id, cdev->id);
-	else
-		goto end;
-	acpi_driver_data(device) = cdev;
-	result = sysfs_create_link(&device->dev.kobj, &cdev->device.kobj,
-					"thermal_cooling");
-	if (result)
-		return result;
 
-	result = sysfs_create_link(&cdev->device.kobj, &device->dev.kobj,
-                                       "device");
-        if (result)
-                return result;
+		acpi_driver_data(device) = cdev;
+		result = sysfs_create_link(&device->dev.kobj,
+					   &cdev->device.kobj,
+					   "thermal_cooling");
+		if (result)
+			return result;
+
+		result = sysfs_create_link(&cdev->device.kobj,
+					   &device->dev.kobj,
+					   "device");
+		if (result)
+			return result;
+	}
 
 	result = acpi_fan_add_fs(device);
 	if (result)