From 54944d0693be9c603105c95599703feff82f88ab Mon Sep 17 00:00:00 2001 From: Dave Jones Date: Fri, 25 Jul 2008 01:45:55 -0700 Subject: [PATCH] --- yaml --- r: 105819 b: refs/heads/master c: 924d9addb9b1474fc81a78a5c6706755efea7aaa h: refs/heads/master i: 105817: 34fd604b0b317a6c63ae99ff741661ab6ae35833 105815: 101edeb370dd75f5558439e5d1a82007ee757194 v: v3 --- [refs] | 2 +- trunk/lib/list_debug.c | 36 ++++++++++++++---------------------- 2 files changed, 15 insertions(+), 23 deletions(-) diff --git a/[refs] b/[refs] index 3dbce528bbf2..2c5f6f1862bd 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: d955c78ac4699ac9c3fe07be62982cda13d13267 +refs/heads/master: 924d9addb9b1474fc81a78a5c6706755efea7aaa diff --git a/trunk/lib/list_debug.c b/trunk/lib/list_debug.c index 45c03fd608dd..1a39f4e3ae1f 100644 --- a/trunk/lib/list_debug.c +++ b/trunk/lib/list_debug.c @@ -20,18 +20,14 @@ void __list_add(struct list_head *new, struct list_head *prev, struct list_head *next) { - if (unlikely(next->prev != prev)) { - printk(KERN_ERR "list_add corruption. next->prev should be " - "prev (%p), but was %p. (next=%p).\n", - prev, next->prev, next); - BUG(); - } - if (unlikely(prev->next != next)) { - printk(KERN_ERR "list_add corruption. prev->next should be " - "next (%p), but was %p. (prev=%p).\n", - next, prev->next, prev); - BUG(); - } + WARN(next->prev != prev, + "list_add corruption. next->prev should be " + "prev (%p), but was %p. (next=%p).\n", + prev, next->prev, next); + WARN(prev->next != next, + "list_add corruption. prev->next should be " + "next (%p), but was %p. (prev=%p).\n", + next, prev->next, prev); next->prev = new; new->next = next; new->prev = prev; @@ -47,16 +43,12 @@ EXPORT_SYMBOL(__list_add); */ void list_del(struct list_head *entry) { - if (unlikely(entry->prev->next != entry)) { - printk(KERN_ERR "list_del corruption. prev->next should be %p, " - "but was %p\n", entry, entry->prev->next); - BUG(); - } - if (unlikely(entry->next->prev != entry)) { - printk(KERN_ERR "list_del corruption. next->prev should be %p, " - "but was %p\n", entry, entry->next->prev); - BUG(); - } + WARN(entry->prev->next != entry, + "list_del corruption. prev->next should be %p, " + "but was %p\n", entry, entry->prev->next); + WARN(entry->next->prev != entry, + "list_del corruption. next->prev should be %p, " + "but was %p\n", entry, entry->next->prev); __list_del(entry->prev, entry->next); entry->next = LIST_POISON1; entry->prev = LIST_POISON2;