From 5e3a4d6b09ad25e04fadf5130527185dc3fc4046 Mon Sep 17 00:00:00 2001
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 2 Nov 2009 12:21:06 +0100
Subject: [PATCH] --- yaml --- r: 171115 b: refs/heads/master c:
 536b2e92f1b7a86e177aeced097e4c051eeebe7d h: refs/heads/master i:   171113:
 c3a90c85e32ada653c1b3d5b2c3d52f55f251d65   171111:
 77987666593d1719895d7ee662b7370a64bbde36 v: v3

---
 [refs]                    |  2 +-
 trunk/net/ipv6/datagram.c | 14 +++++++++-----
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/[refs] b/[refs]
index 5216950b7075..07716676b49c 100644
--- a/[refs]
+++ b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 16ba5e8e7c01d2da87ff1d17e83545f164665b5c
+refs/heads/master: 536b2e92f1b7a86e177aeced097e4c051eeebe7d
diff --git a/trunk/net/ipv6/datagram.c b/trunk/net/ipv6/datagram.c
index 9f70452a69e7..e6f9cdf780fe 100644
--- a/trunk/net/ipv6/datagram.c
+++ b/trunk/net/ipv6/datagram.c
@@ -537,12 +537,17 @@ int datagram_send_ctl(struct net *net,
 
 			addr_type = __ipv6_addr_type(&src_info->ipi6_addr);
 
+			rcu_read_lock();
 			if (fl->oif) {
-				dev = dev_get_by_index(net, fl->oif);
-				if (!dev)
+				dev = dev_get_by_index_rcu(net, fl->oif);
+				if (!dev) {
+					rcu_read_unlock();
 					return -ENODEV;
-			} else if (addr_type & IPV6_ADDR_LINKLOCAL)
+				}
+			} else if (addr_type & IPV6_ADDR_LINKLOCAL) {
+				rcu_read_unlock();
 				return -EINVAL;
+			}
 
 			if (addr_type != IPV6_ADDR_ANY) {
 				int strict = __ipv6_addr_src_scope(addr_type) <= IPV6_ADDR_SCOPE_LINKLOCAL;
@@ -553,8 +558,7 @@ int datagram_send_ctl(struct net *net,
 					ipv6_addr_copy(&fl->fl6_src, &src_info->ipi6_addr);
 			}
 
-			if (dev)
-				dev_put(dev);
+			rcu_read_unlock();
 
 			if (err)
 				goto exit_f;