From 60667af125cb2dc434c11e1633291ce27eecb7f8 Mon Sep 17 00:00:00 2001 From: Oleg Nesterov Date: Mon, 26 Jun 2006 00:26:08 -0700 Subject: [PATCH] --- yaml --- r: 30266 b: refs/heads/master c: 7b1c6154fa8bb937e0b1b4f2adbb315d70270f10 h: refs/heads/master v: v3 --- [refs] | 2 +- trunk/fs/exec.c | 12 ++++++++---- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/[refs] b/[refs] index 2aff974f74a1..96bbae2ad5c0 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: d5f70c00ad24cd1158d3678b44ff969b4c971d49 +refs/heads/master: 7b1c6154fa8bb937e0b1b4f2adbb315d70270f10 diff --git a/trunk/fs/exec.c b/trunk/fs/exec.c index b58ba7d127e0..49fa0127a330 100644 --- a/trunk/fs/exec.c +++ b/trunk/fs/exec.c @@ -1373,7 +1373,11 @@ static void zap_process(struct task_struct *start) struct task_struct *t; unsigned long flags; - spin_lock_irqsave(&start->sighand->siglock, flags); + /* + * start->sighand can't disappear, but may be + * changed by de_thread() + */ + lock_task_sighand(start, &flags); start->signal->flags = SIGNAL_GROUP_EXIT; start->signal->group_stop_count = 0; @@ -1386,7 +1390,7 @@ static void zap_process(struct task_struct *start) } } while ((t = next_thread(t)) != start); - spin_unlock_irqrestore(&start->sighand->siglock, flags); + unlock_task_sighand(start, &flags); } static void zap_threads(struct mm_struct *mm) @@ -1404,7 +1408,7 @@ static void zap_threads(struct mm_struct *mm) complete(vfork_done); } - read_lock(&tasklist_lock); + rcu_read_lock(); for_each_process(g) { p = g; do { @@ -1415,7 +1419,7 @@ static void zap_threads(struct mm_struct *mm) } } while ((p = next_thread(p)) != g); } - read_unlock(&tasklist_lock); + rcu_read_unlock(); } static void coredump_wait(struct mm_struct *mm)