From 657d902ae4da3f3d090455fe705d207987c966f0 Mon Sep 17 00:00:00 2001 From: Christoph Lameter Date: Wed, 5 Sep 2012 00:20:33 +0000 Subject: [PATCH] --- yaml --- r: 330433 b: refs/heads/master c: 686d550d222e8f83f6e709debbedf9d8ef77aec7 h: refs/heads/master i: 330431: f966565667d267685af6e66544ae827551401d45 v: v3 --- [refs] | 2 +- trunk/mm/slab_common.c | 28 ++++++++++++++++++++++++---- 2 files changed, 25 insertions(+), 5 deletions(-) diff --git a/[refs] b/[refs] index 79b65906c75a..3757324b607c 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 208c4358dc4a8f0fe99e49eb8d21a869b01e7d34 +refs/heads/master: 686d550d222e8f83f6e709debbedf9d8ef77aec7 diff --git a/trunk/mm/slab_common.c b/trunk/mm/slab_common.c index 8cf8b4962d6c..fe8dc943c285 100644 --- a/trunk/mm/slab_common.c +++ b/trunk/mm/slab_common.c @@ -98,16 +98,36 @@ struct kmem_cache *kmem_cache_create(const char *name, size_t size, size_t align unsigned long flags, void (*ctor)(void *)) { struct kmem_cache *s = NULL; + int err = 0; get_online_cpus(); mutex_lock(&slab_mutex); - if (kmem_cache_sanity_check(name, size) == 0) - s = __kmem_cache_create(name, size, align, flags, ctor); + + if (!kmem_cache_sanity_check(name, size) == 0) + goto out_locked; + + + s = __kmem_cache_create(name, size, align, flags, ctor); + if (!s) + err = -ENOSYS; /* Until __kmem_cache_create returns code */ + +out_locked: mutex_unlock(&slab_mutex); put_online_cpus(); - if (!s && (flags & SLAB_PANIC)) - panic("kmem_cache_create: Failed to create slab '%s'\n", name); + if (err) { + + if (flags & SLAB_PANIC) + panic("kmem_cache_create: Failed to create slab '%s'. Error %d\n", + name, err); + else { + printk(KERN_WARNING "kmem_cache_create(%s) failed with error %d", + name, err); + dump_stack(); + } + + return NULL; + } return s; }