From 661855d1812d99a5f0544ad7ed0bbc52a6241f4c Mon Sep 17 00:00:00 2001 From: Tejun Heo Date: Fri, 17 Jul 2009 11:58:33 +0900 Subject: [PATCH] --- yaml --- r: 158503 b: refs/heads/master c: 1e641060c4b564e820abdb6a4c7a603a0d386250 h: refs/heads/master i: 158501: 013fe02af3b208522284ad9b3961f1cfdb62dcea 158499: 0b8b23e30434e529d46faf9f6993b5def13dbbc0 158495: f360db34b16da0c52af2ef6b8b491443862b20ca v: v3 --- [refs] | 2 +- trunk/drivers/ata/libata-eh.c | 12 +++++++++--- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/[refs] b/[refs] index bbbe29544b99..c533c06ac9a2 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 388539f3ff0cf1de926b03f94e1eec112358f74d +refs/heads/master: 1e641060c4b564e820abdb6a4c7a603a0d386250 diff --git a/trunk/drivers/ata/libata-eh.c b/trunk/drivers/ata/libata-eh.c index 9159abe5211c..2c34de841e11 100644 --- a/trunk/drivers/ata/libata-eh.c +++ b/trunk/drivers/ata/libata-eh.c @@ -2576,11 +2576,17 @@ int ata_eh_reset(struct ata_link *link, int classify, postreset(slave, classes); } - /* clear cached SError */ + /* + * Some controllers can't be frozen very well and may set + * spuruious error conditions during reset. Clear accumulated + * error information. As reset is the final recovery action, + * nothing is lost by doing this. + */ spin_lock_irqsave(link->ap->lock, flags); - link->eh_info.serror = 0; + memset(&link->eh_info, 0, sizeof(link->eh_info)); if (slave) - slave->eh_info.serror = 0; + memset(&slave->eh_info, 0, sizeof(link->eh_info)); + ap->pflags &= ~ATA_PFLAG_EH_PENDING; spin_unlock_irqrestore(link->ap->lock, flags); /* Make sure onlineness and classification result correspond.