From 674bdab6c341cb573548411f1e12b6a6c73ff27d Mon Sep 17 00:00:00 2001 From: Arnaldo Carvalho de Melo Date: Tue, 17 Nov 2009 01:18:11 -0200 Subject: [PATCH] --- yaml --- r: 169638 b: refs/heads/master c: a9a70bbce7ab0bf3b1cba3ac662c4d502da6305c h: refs/heads/master v: v3 --- [refs] | 2 +- trunk/tools/perf/builtin-record.c | 5 +++++ trunk/tools/perf/util/header.c | 18 +++++++++++------- 3 files changed, 17 insertions(+), 8 deletions(-) diff --git a/[refs] b/[refs] index 5be3c20c61e6..14f51a28b19c 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 5875412152ce67fb5087157b86ab6597f91d23e8 +refs/heads/master: a9a70bbce7ab0bf3b1cba3ac662c4d502da6305c diff --git a/trunk/tools/perf/builtin-record.c b/trunk/tools/perf/builtin-record.c index 2a85205ba01a..82260c56db3d 100644 --- a/trunk/tools/perf/builtin-record.c +++ b/trunk/tools/perf/builtin-record.c @@ -439,6 +439,11 @@ static int __cmd_record(int argc, const char **argv) else header = perf_header__new(); + if (header == NULL) { + pr_err("Not enough memory for reading perf file header\n"); + return -1; + } + if (raw_samples) { perf_header__set_feat(header, HEADER_TRACE_INFO); } else { diff --git a/trunk/tools/perf/util/header.c b/trunk/tools/perf/util/header.c index dee1ed2f0d1b..726a0eb5f197 100644 --- a/trunk/tools/perf/util/header.c +++ b/trunk/tools/perf/util/header.c @@ -65,14 +65,15 @@ struct perf_header *perf_header__new(void) { struct perf_header *self = calloc(sizeof(*self), 1); - if (!self) - die("nomem"); - - self->size = 1; - self->attr = malloc(sizeof(void *)); + if (self != NULL) { + self->size = 1; + self->attr = malloc(sizeof(void *)); - if (!self->attr) - die("nomem"); + if (self->attr == NULL) { + free(self); + self = NULL; + } + } return self; } @@ -426,6 +427,9 @@ struct perf_header *perf_header__read(int fd) u64 f_id; int nr_attrs, nr_ids, i, j; + if (self == NULL) + die("nomem"); + if (perf_file_header__read(&f_header, self, fd) < 0) die("incompatible file format");