From 6fca28ed0cec91872510658b8aeac695e8f11812 Mon Sep 17 00:00:00 2001 From: Hannes Reinecke Date: Wed, 18 Feb 2009 10:30:15 +0100 Subject: [PATCH] --- yaml --- r: 131525 b: refs/heads/master c: be987fdb55a4726e2fcbab7501f89276bdb57288 h: refs/heads/master i: 131523: b1bc0a6a957c9d16a0fb51564e8584424fe0748a v: v3 --- [refs] | 2 +- trunk/block/blk-timeout.c | 9 ++++++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/[refs] b/[refs] index 7783d1d977d4..3f1012790954 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 41b8c853a495438208faa5be03bbb0050859163b +refs/heads/master: be987fdb55a4726e2fcbab7501f89276bdb57288 diff --git a/trunk/block/blk-timeout.c b/trunk/block/blk-timeout.c index a09535377a94..bbbdc4b8ccf2 100644 --- a/trunk/block/blk-timeout.c +++ b/trunk/block/blk-timeout.c @@ -209,12 +209,19 @@ void blk_abort_queue(struct request_queue *q) { unsigned long flags; struct request *rq, *tmp; + LIST_HEAD(list); spin_lock_irqsave(q->queue_lock, flags); elv_abort_queue(q); - list_for_each_entry_safe(rq, tmp, &q->timeout_list, timeout_list) + /* + * Splice entries to local list, to avoid deadlocking if entries + * get readded to the timeout list by error handling + */ + list_splice_init(&q->timeout_list, &list); + + list_for_each_entry_safe(rq, tmp, &list, timeout_list) blk_abort_request(rq); spin_unlock_irqrestore(q->queue_lock, flags);