From 7468a204f170512d9911c15121fed21f267323e2 Mon Sep 17 00:00:00 2001 From: Axel Lin Date: Tue, 13 Jul 2010 09:25:12 -0700 Subject: [PATCH] --- yaml --- r: 202205 b: refs/heads/master c: 02b5fac1f71c21a84da025973ccb14e4ec6f6d4a h: refs/heads/master i: 202203: 6c5d8a32ae2fecc1524670ec88334ca82b504539 v: v3 --- [refs] | 2 +- trunk/drivers/input/misc/atlas_btns.c | 14 ++++++-------- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/[refs] b/[refs] index de279044567a..f006264e8f97 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 07d19ffce54faa5591954bab3644b6f2ff31640c +refs/heads/master: 02b5fac1f71c21a84da025973ccb14e4ec6f6d4a diff --git a/trunk/drivers/input/misc/atlas_btns.c b/trunk/drivers/input/misc/atlas_btns.c index 7d5360869047..2391a86aeb0f 100644 --- a/trunk/drivers/input/misc/atlas_btns.c +++ b/trunk/drivers/input/misc/atlas_btns.c @@ -60,12 +60,12 @@ static acpi_status acpi_atlas_button_handler(u32 function, input_report_key(input_dev, atlas_keymap[code], key_down); input_sync(input_dev); - status = 0; + status = AE_OK; } else { printk(KERN_WARNING "atlas: shrugged on unexpected function" ":function=%x,address=%lx,value=%x\n", function, (unsigned long)address, (u32)*value); - status = -EINVAL; + status = AE_BAD_PARAMETER; } return status; @@ -114,10 +114,10 @@ static int atlas_acpi_button_add(struct acpi_device *device) if (ACPI_FAILURE(status)) { printk(KERN_ERR "Atlas: Error installing addr spc handler\n"); input_unregister_device(input_dev); - status = -EINVAL; + err = -EINVAL; } - return status; + return err; } static int atlas_acpi_button_remove(struct acpi_device *device, int type) @@ -126,14 +126,12 @@ static int atlas_acpi_button_remove(struct acpi_device *device, int type) status = acpi_remove_address_space_handler(device->handle, 0x81, &acpi_atlas_button_handler); - if (ACPI_FAILURE(status)) { + if (ACPI_FAILURE(status)) printk(KERN_ERR "Atlas: Error removing addr spc handler\n"); - status = -EINVAL; - } input_unregister_device(input_dev); - return status; + return 0; } static const struct acpi_device_id atlas_device_ids[] = {