From 748f75b11a7f590d3a1909ef717f9bc5113cd574 Mon Sep 17 00:00:00 2001
From: Hans Verkuil <hans.verkuil@cisco.com>
Date: Tue, 14 Jun 2011 11:01:52 -0300
Subject: [PATCH] --- yaml --- r: 261407 b: refs/heads/master c:
 71c6c4c918696625164ffdac4ece9f83bd4a6694 h: refs/heads/master i:   261405:
 a189e4eb7213b93f36176659353e353964853262   261403:
 3cc506274a2f7c27fbd6a51d1177ea55bcccd980   261399:
 235d8efe24398566d875b6412a11c78e1f281e0d   261391:
 208f7ca94660afb883c538d909c65ca80bf88ec8   261375:
 bfd474e31106807292a86336e52c3a6e1457e881 v: v3

---
 [refs]                                 |  2 +-
 trunk/drivers/media/video/v4l2-ctrls.c | 13 ++++---------
 2 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/[refs] b/[refs]
index 1fc8ffa52033..f03c8c037179 100644
--- a/[refs]
+++ b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: e64025850d11afd0a9ad14d40310bec7ff0f4847
+refs/heads/master: 71c6c4c918696625164ffdac4ece9f83bd4a6694
diff --git a/trunk/drivers/media/video/v4l2-ctrls.c b/trunk/drivers/media/video/v4l2-ctrls.c
index eb6d6fd9b92d..cc2b589140d2 100644
--- a/trunk/drivers/media/video/v4l2-ctrls.c
+++ b/trunk/drivers/media/video/v4l2-ctrls.c
@@ -1411,26 +1411,21 @@ int v4l2_ctrl_handler_setup(struct v4l2_ctrl_handler *hdl)
 		int i;
 
 		/* Skip if this control was already handled by a cluster. */
-		if (ctrl->done)
+		/* Skip button controls and read-only controls. */
+		if (ctrl->done || ctrl->type == V4L2_CTRL_TYPE_BUTTON ||
+		    (ctrl->flags & V4L2_CTRL_FLAG_READ_ONLY))
 			continue;
 
 		for (i = 0; i < master->ncontrols; i++) {
 			if (master->cluster[i]) {
 				cur_to_new(master->cluster[i]);
 				master->cluster[i]->is_new = 1;
+				master->cluster[i]->done = true;
 			}
 		}
-
-		/* Skip button controls and read-only controls. */
-		if (ctrl->type == V4L2_CTRL_TYPE_BUTTON ||
-		    (ctrl->flags & V4L2_CTRL_FLAG_READ_ONLY))
-			continue;
 		ret = call_op(master, s_ctrl);
 		if (ret)
 			break;
-		for (i = 0; i < master->ncontrols; i++)
-			if (master->cluster[i])
-				master->cluster[i]->done = true;
 	}
 	mutex_unlock(&hdl->lock);
 	return ret;