From 7653c14a1524a95bcbed21b96397358a832c6df7 Mon Sep 17 00:00:00 2001 From: Jiri Slaby Date: Mon, 30 Jan 2012 21:14:32 +0100 Subject: [PATCH] --- yaml --- r: 289274 b: refs/heads/master c: d3bda5298aad98c7a27678bdd0dd9d008ab9e685 h: refs/heads/master v: v3 --- [refs] | 2 +- trunk/drivers/tty/pty.c | 6 ++---- trunk/drivers/tty/tty_io.c | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/[refs] b/[refs] index 1fe46cf561f0..1dae5a52d486 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: a50f724a432997321cabb6c9e665c28e34850f78 +refs/heads/master: d3bda5298aad98c7a27678bdd0dd9d008ab9e685 diff --git a/trunk/drivers/tty/pty.c b/trunk/drivers/tty/pty.c index ddec9f3c3396..39afd045f8ef 100644 --- a/trunk/drivers/tty/pty.c +++ b/trunk/drivers/tty/pty.c @@ -54,8 +54,8 @@ static void pty_close(struct tty_struct *tty, struct file *filp) wake_up_interruptible(&tty->link->write_wait); if (tty->driver->subtype == PTY_TYPE_MASTER) { set_bit(TTY_OTHER_CLOSED, &tty->flags); - devpts_pty_kill(tty->link); tty_unlock(); + devpts_pty_kill(tty->link); tty_vhangup(tty->link); tty_lock(); } @@ -613,9 +613,7 @@ static int ptmx_open(struct inode *inode, struct file *filp) return retval; /* find a device that is not in use. */ - tty_lock(); index = devpts_new_index(inode); - tty_unlock(); if (index < 0) { retval = index; goto err_file; @@ -650,8 +648,8 @@ static int ptmx_open(struct inode *inode, struct file *filp) tty_release(inode, filp); return retval; out: - devpts_kill_index(inode, index); tty_unlock(); + devpts_kill_index(inode, index); err_file: tty_free_file(filp); return retval; diff --git a/trunk/drivers/tty/tty_io.c b/trunk/drivers/tty/tty_io.c index 44736f9e61d7..ea7ebe22a16c 100644 --- a/trunk/drivers/tty/tty_io.c +++ b/trunk/drivers/tty/tty_io.c @@ -1789,11 +1789,11 @@ int tty_release(struct inode *inode, struct file *filp) * the slots and preserving the termios structure. */ release_tty(tty, idx); + tty_unlock(); /* Make this pty number available for reallocation */ if (devpts) devpts_kill_index(inode, idx); - tty_unlock(); return 0; }