From 7d057a5b847e82def9fd4b0316c978f180502a1f Mon Sep 17 00:00:00 2001 From: Roland Dreier Date: Thu, 24 Jul 2008 20:36:59 -0700 Subject: [PATCH] --- yaml --- r: 106460 b: refs/heads/master c: 5ba18b186c979283a2bf75a28b7ea325184b0c08 h: refs/heads/master v: v3 --- [refs] | 2 +- trunk/drivers/infiniband/core/ucm.c | 10 ++++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/[refs] b/[refs] index 5e27263e9f90..dafc14468a1e 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: f7a6117ee59c0001d58e830a82d7e205ed602bdd +refs/heads/master: 5ba18b186c979283a2bf75a28b7ea325184b0c08 diff --git a/trunk/drivers/infiniband/core/ucm.c b/trunk/drivers/infiniband/core/ucm.c index 9494005d1c9a..e603736682bf 100644 --- a/trunk/drivers/infiniband/core/ucm.c +++ b/trunk/drivers/infiniband/core/ucm.c @@ -43,7 +43,6 @@ #include #include #include -#include #include @@ -1154,11 +1153,18 @@ static unsigned int ib_ucm_poll(struct file *filp, return mask; } +/* + * ib_ucm_open() does not need the BKL: + * + * - no global state is referred to; + * - there is no ioctl method to race against; + * - no further module initialization is required for open to work + * after the device is registered. + */ static int ib_ucm_open(struct inode *inode, struct file *filp) { struct ib_ucm_file *file; - cycle_kernel_lock(); file = kmalloc(sizeof(*file), GFP_KERNEL); if (!file) return -ENOMEM;