From 862c4534b57fb4ee2e41924b3b8fd2a8db848474 Mon Sep 17 00:00:00 2001 From: Julia Lawall Date: Tue, 15 Nov 2011 14:53:11 -0800 Subject: [PATCH] --- yaml --- r: 275909 b: refs/heads/master c: c916874d60d9daf2e2d5f4f622b185ef57deb6a4 h: refs/heads/master i: 275907: 42cd7777907efec3085517ce41250257b7dd2032 v: v3 --- [refs] | 2 +- trunk/drivers/gpu/vga/vgaarb.c | 18 ++++++++++++------ 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/[refs] b/[refs] index 0d6b56e57b8e..dcbcd7506fc0 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 21240f9bc1b0ac925cd18b74618327a110022332 +refs/heads/master: c916874d60d9daf2e2d5f4f622b185ef57deb6a4 diff --git a/trunk/drivers/gpu/vga/vgaarb.c b/trunk/drivers/gpu/vga/vgaarb.c index bdde899af72e..111d956d8e7d 100644 --- a/trunk/drivers/gpu/vga/vgaarb.c +++ b/trunk/drivers/gpu/vga/vgaarb.c @@ -991,14 +991,20 @@ static ssize_t vga_arb_write(struct file *file, const char __user * buf, uc = &priv->cards[i]; } - if (!uc) - return -EINVAL; + if (!uc) { + ret_val = -EINVAL; + goto done; + } - if (io_state & VGA_RSRC_LEGACY_IO && uc->io_cnt == 0) - return -EINVAL; + if (io_state & VGA_RSRC_LEGACY_IO && uc->io_cnt == 0) { + ret_val = -EINVAL; + goto done; + } - if (io_state & VGA_RSRC_LEGACY_MEM && uc->mem_cnt == 0) - return -EINVAL; + if (io_state & VGA_RSRC_LEGACY_MEM && uc->mem_cnt == 0) { + ret_val = -EINVAL; + goto done; + } vga_put(pdev, io_state);