From 8a7f1461e9230be80571ad8ef157e7510e5a0b81 Mon Sep 17 00:00:00 2001 From: Guenter Roeck Date: Sat, 2 Jun 2012 09:58:03 -0700 Subject: [PATCH] --- yaml --- r: 315983 b: refs/heads/master c: d466a353052582ea784d9f5352c822d828d00244 h: refs/heads/master i: 315981: 8f0622a0b193c88f8959c1838c2c5adbdf11e183 315979: 472c91a0612fd0c2f978d4176ce884e553cfa924 315975: 59b520ada511e6239a29567c76474739188c0c67 315967: c822396987e5cb69463d29c39e34984c21f80ce5 v: v3 --- [refs] | 2 +- trunk/drivers/hwmon/atxp1.c | 16 +++++----------- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/[refs] b/[refs] index b3fcb9d8138d..2f62a35bbbb8 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: e5ebb772c697540f42a4b74f3d14fae6ecd4de24 +refs/heads/master: d466a353052582ea784d9f5352c822d828d00244 diff --git a/trunk/drivers/hwmon/atxp1.c b/trunk/drivers/hwmon/atxp1.c index 58af6aa93530..aecb9ea7beb5 100644 --- a/trunk/drivers/hwmon/atxp1.c +++ b/trunk/drivers/hwmon/atxp1.c @@ -345,11 +345,10 @@ static int atxp1_probe(struct i2c_client *new_client, struct atxp1_data *data; int err; - data = kzalloc(sizeof(struct atxp1_data), GFP_KERNEL); - if (!data) { - err = -ENOMEM; - goto exit; - } + data = devm_kzalloc(&new_client->dev, sizeof(struct atxp1_data), + GFP_KERNEL); + if (!data) + return -ENOMEM; /* Get VRM */ data->vrm = vid_which_vrm(); @@ -362,7 +361,7 @@ static int atxp1_probe(struct i2c_client *new_client, /* Register sysfs hooks */ err = sysfs_create_group(&new_client->dev.kobj, &atxp1_group); if (err) - goto exit_free; + return err; data->hwmon_dev = hwmon_device_register(&new_client->dev); if (IS_ERR(data->hwmon_dev)) { @@ -377,9 +376,6 @@ static int atxp1_probe(struct i2c_client *new_client, exit_remove_files: sysfs_remove_group(&new_client->dev.kobj, &atxp1_group); -exit_free: - kfree(data); -exit: return err; }; @@ -390,8 +386,6 @@ static int atxp1_remove(struct i2c_client *client) hwmon_device_unregister(data->hwmon_dev); sysfs_remove_group(&client->dev.kobj, &atxp1_group); - kfree(data); - return 0; };