From 8c534201988adcba62724b5e9e03dfd23a586e23 Mon Sep 17 00:00:00 2001 From: Li Zefan Date: Wed, 10 Mar 2010 15:22:12 -0800 Subject: [PATCH] --- yaml --- r: 187211 b: refs/heads/master c: b70cc5fdb445a6929a01e9c406593265b136c99d h: refs/heads/master i: 187209: fa1e2afa43653994cf54915dbbbd504006c34ce6 187207: ab0468a6cea7f88a1dada933562d017cde40b968 v: v3 --- [refs] | 2 +- trunk/kernel/cgroup.c | 8 +++----- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/[refs] b/[refs] index 68d805d381f3..1b18e8258821 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 67523c48aa74d5637848edeccf285af1c60bf14a +refs/heads/master: b70cc5fdb445a6929a01e9c406593265b136c99d diff --git a/trunk/kernel/cgroup.c b/trunk/kernel/cgroup.c index 521591dbab2f..1bf4d6db54ab 100644 --- a/trunk/kernel/cgroup.c +++ b/trunk/kernel/cgroup.c @@ -2597,7 +2597,8 @@ static struct cgroup_pidlist *cgroup_pidlist_find(struct cgroup *cgrp, { struct cgroup_pidlist *l; /* don't need task_nsproxy() if we're looking at ourself */ - struct pid_namespace *ns = get_pid_ns(current->nsproxy->pid_ns); + struct pid_namespace *ns = current->nsproxy->pid_ns; + /* * We can't drop the pidlist_mutex before taking the l->mutex in case * the last ref-holder is trying to remove l from the list at the same @@ -2607,8 +2608,6 @@ static struct cgroup_pidlist *cgroup_pidlist_find(struct cgroup *cgrp, mutex_lock(&cgrp->pidlist_mutex); list_for_each_entry(l, &cgrp->pidlists, links) { if (l->key.type == type && l->key.ns == ns) { - /* found a matching list - drop the extra refcount */ - put_pid_ns(ns); /* make sure l doesn't vanish out from under us */ down_write(&l->mutex); mutex_unlock(&cgrp->pidlist_mutex); @@ -2619,13 +2618,12 @@ static struct cgroup_pidlist *cgroup_pidlist_find(struct cgroup *cgrp, l = kmalloc(sizeof(struct cgroup_pidlist), GFP_KERNEL); if (!l) { mutex_unlock(&cgrp->pidlist_mutex); - put_pid_ns(ns); return l; } init_rwsem(&l->mutex); down_write(&l->mutex); l->key.type = type; - l->key.ns = ns; + l->key.ns = get_pid_ns(ns); l->use_count = 0; /* don't increment here */ l->list = NULL; l->owner = cgrp;