From 8fe251851230e9e8c2e89b569436af8c0edc05aa Mon Sep 17 00:00:00 2001 From: Davi Arnaut Date: Wed, 1 Feb 2006 03:06:40 -0800 Subject: [PATCH] --- yaml --- r: 19448 b: refs/heads/master c: 172411f10c25bbd81b19f67566af6a7f549f46a9 h: refs/heads/master v: v3 --- [refs] | 2 +- trunk/drivers/s390/char/keyboard.c | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/[refs] b/[refs] index 24bd2870a936..8cec24aa71ee 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 46d0d2c811c8e9dd5cffdc3a5c03d988eb5a2996 +refs/heads/master: 172411f10c25bbd81b19f67566af6a7f549f46a9 diff --git a/trunk/drivers/s390/char/keyboard.c b/trunk/drivers/s390/char/keyboard.c index 5bda2340a39d..a317a123daba 100644 --- a/trunk/drivers/s390/char/keyboard.c +++ b/trunk/drivers/s390/char/keyboard.c @@ -440,7 +440,11 @@ do_kdgkb_ioctl(struct kbd_data *kbd, struct kbsentry __user *u_kbs, return -EPERM; len = strnlen_user(u_kbs->kb_string, sizeof(u_kbs->kb_string) - 1); - p = kmalloc(len, GFP_KERNEL); + if (!len) + return -EFAULT; + if (len > sizeof(u_kbs->kb_string) - 1) + return -EINVAL; + p = kmalloc(len + 1, GFP_KERNEL); if (!p) return -ENOMEM; if (copy_from_user(p, u_kbs->kb_string, len)) {